public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: "Van De Ven, Arjan" <arjan.van.de.ven@intel.com>
Cc: Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	"Wu, Xia" <xia.wu@intel.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"mingo@elte.hu" <mingo@elte.hu>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Zhu, Daniel" <daniel.zhu@intel.com>,
	"Wang, Yong Y" <yong.y.wang@intel.com>
Subject: Re: unnecessary timer interrupt of slab.c and bdi tasks when the system is in sleep state
Date: Fri, 1 Oct 2010 16:36:10 +0200	[thread overview]
Message-ID: <20101001143546.GA6194@nowhere> (raw)
In-Reply-To: <26E9B811E137AB4B95200FD4C950886BA64E0E96@orsmsx507.amr.corp.intel.com>

On Fri, Oct 01, 2010 at 07:22:10AM -0700, Van De Ven, Arjan wrote:
> > > > I found some unnecessary timer interrupts when the system enter
> > sleep state.
> > > > (1)     /mm/slab.c
> > > > cache_reap() clean up on allocated memory every 2s. If the system
> > is in sleep state, the system is waked-up when this timer expires. In
> > fact,
> > > > there isn't more slabs to been cleaned up in sleep state.
> > >
> > > Right. We could switch off the timer when idle without much of an
> > issue.
> > > The expiration of the caches wont occur and so we will have stale
> > objects
> > > on the queues when we exit sleep state. You could flush the queues
> > before
> > > switching off the timers?
> > 
> > 
> > May be flushing the queue everytime we enter nohz is too much, as that
> > can
> > happen very often?
> > 
> 
> 
> the slab timer is already deferable... which means it won't hit while the system is completely idle.


I'm not sure what you mean exactly. The slab work seems to be scheduled strictly
periodically, unless the cpu goes offline. But I can't find any nohz-wise adaptation.



> I think this part of the original report is a red herring found on an older kernel.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


  reply	other threads:[~2010-10-01 14:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <A24AE1FFE7AEC5489F83450EE98351BF221878E0FB@shsmsx502.ccr.corp.intel.com>
2010-09-30 14:13 ` unnecessary timer interrupt of slab.c and bdi tasks when the system is in sleep state Christoph Lameter
2010-10-01 14:20   ` Frederic Weisbecker
2010-10-01 14:22     ` Van De Ven, Arjan
2010-10-01 14:36       ` Frederic Weisbecker [this message]
2010-10-01 15:20         ` Van De Ven, Arjan
2010-10-01 15:27           ` Frederic Weisbecker
2010-09-30  4:02 Wu, Xia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101001143546.GA6194@nowhere \
    --to=fweisbec@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan.van.de.ven@intel.com \
    --cc=cl@linux.com \
    --cc=daniel.zhu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xia.wu@intel.com \
    --cc=yong.y.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox