* [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt
@ 2010-09-20 6:33 matt mooney
2010-09-29 15:03 ` Michal Marek
0 siblings, 1 reply; 6+ messages in thread
From: matt mooney @ 2010-09-20 6:33 UTC (permalink / raw)
To: Michal Marek, Randy Dunlap
Cc: linux-kbuild, linux-kernel, linux-doc, kernel-janitors
Change $(src) and $(obj) definitions to state the path as absolute and
not relative.
Signed-off-by: matt mooney <mfm@muteddisk.com>
---
Hmm, this file is also _full_ of bad grammar and might be out of date FAIK.
If you would like it updated/corrected, please let me know. I don't mind doing
this, but only if it is beneficial and wanted.
Documentation/kbuild/makefiles.txt | 11 +++++------
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/Documentation/kbuild/makefiles.txt b/Documentation/kbuild/makefiles.txt
index c787ae5..fe162f5 100644
--- a/Documentation/kbuild/makefiles.txt
+++ b/Documentation/kbuild/makefiles.txt
@@ -376,14 +376,13 @@ more details, with real examples.
Two variables are used when defining special rules:
$(src)
- $(src) is a relative path which points to the directory
- where the Makefile is located. Always use $(src) when
- referring to files located in the src tree.
+ The absolute path to the directory where the makefile is
+ located. Always use $(src) when referring to files located
+ in the src directory.
$(obj)
- $(obj) is a relative path which points to the directory
- where the target is saved. Always use $(obj) when
- referring to generated files.
+ The absolute path to the directory where the target is saved.
+ Always use $(obj) when referring to generated files.
Example:
#drivers/scsi/Makefile
--
1.7.2.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt
2010-09-20 6:33 [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt matt mooney
@ 2010-09-29 15:03 ` Michal Marek
2010-09-29 17:50 ` Sam Ravnborg
0 siblings, 1 reply; 6+ messages in thread
From: Michal Marek @ 2010-09-29 15:03 UTC (permalink / raw)
To: matt mooney
Cc: Randy Dunlap, linux-kbuild, linux-kernel, linux-doc,
kernel-janitors
On 20.9.2010 08:33, matt mooney wrote:
> Change $(src) and $(obj) definitions to state the path as absolute and
> not relative.
It _is_ a relative patch, AFAICS. What makes you think otherwise?
BTW, I applied your patches to modules.txt, thanks for them.
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt
2010-09-29 15:03 ` Michal Marek
@ 2010-09-29 17:50 ` Sam Ravnborg
2010-09-29 23:19 ` matt mooney
0 siblings, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2010-09-29 17:50 UTC (permalink / raw)
To: Michal Marek
Cc: matt mooney, Randy Dunlap, linux-kbuild, linux-kernel, linux-doc,
kernel-janitors
On Wed, Sep 29, 2010 at 05:03:29PM +0200, Michal Marek wrote:
> On 20.9.2010 08:33, matt mooney wrote:
> > Change $(src) and $(obj) definitions to state the path as absolute and
> > not relative.
>
> It _is_ a relative patch, AFAICS. What makes you think otherwise?
With extenal modules $(src) and $(obj) are absolute - but in nomal use they are relative.
And again in normal use they are also equal. I usually say that we have two just to document
what is srource and what is generated.
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt
2010-09-29 17:50 ` Sam Ravnborg
@ 2010-09-29 23:19 ` matt mooney
2010-10-01 20:56 ` Michal Marek
0 siblings, 1 reply; 6+ messages in thread
From: matt mooney @ 2010-09-29 23:19 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Michal Marek, Randy Dunlap, linux-kbuild, linux-kernel, linux-doc,
kernel-janitors
On 19:50 Wed 29 Sep , Sam Ravnborg wrote:
> On Wed, Sep 29, 2010 at 05:03:29PM +0200, Michal Marek wrote:
> > On 20.9.2010 08:33, matt mooney wrote:
> > > Change $(src) and $(obj) definitions to state the path as absolute and
> > > not relative.
> >
> > It _is_ a relative patch, AFAICS. What makes you think otherwise?
>
> With extenal modules $(src) and $(obj) are absolute - but in nomal use they are relative.
> And again in normal use they are also equal. I usually say that we have two just to document
> what is srource and what is generated.
Ah, I see. Sorry, I should have looked into this more. Now you did say in normal
use they are equal, but I thought they were also equal when used for an external
module too. Am I missing something?
Thanks,
mfm
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt
2010-09-29 23:19 ` matt mooney
@ 2010-10-01 20:56 ` Michal Marek
2010-10-02 4:14 ` matt mooney
0 siblings, 1 reply; 6+ messages in thread
From: Michal Marek @ 2010-10-01 20:56 UTC (permalink / raw)
To: matt mooney
Cc: Sam Ravnborg, Randy Dunlap, linux-kbuild, linux-kernel, linux-doc,
kernel-janitors
On Wed, Sep 29, 2010 at 04:19:04PM -0700, matt mooney wrote:
> On 19:50 Wed 29 Sep , Sam Ravnborg wrote:
> > On Wed, Sep 29, 2010 at 05:03:29PM +0200, Michal Marek wrote:
> > > On 20.9.2010 08:33, matt mooney wrote:
> > > > Change $(src) and $(obj) definitions to state the path as absolute and
> > > > not relative.
> > >
> > > It _is_ a relative patch, AFAICS. What makes you think otherwise?
> >
> > With extenal modules $(src) and $(obj) are absolute - but in nomal
> > use they are relative.
Ah, I see. Then we should simply say "path", without any adjectives.
> > And again in normal use they are also equal. I usually say that we
> > have two just to document what is srource and what is generated.
>
> Ah, I see. Sorry, I should have looked into this more. Now you did say
> in normal use they are equal, but I thought they were also equal when
> used for an external module too.
Yes, they are, using $(src) for shipped files and $(obj) for generated
ones is just a service for the reader of the Makefile.
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt
2010-10-01 20:56 ` Michal Marek
@ 2010-10-02 4:14 ` matt mooney
0 siblings, 0 replies; 6+ messages in thread
From: matt mooney @ 2010-10-02 4:14 UTC (permalink / raw)
To: Michal Marek
Cc: Sam Ravnborg, Randy Dunlap, linux-kbuild, linux-kernel, linux-doc,
kernel-janitors
On 22:56 Fri 01 Oct , Michal Marek wrote:
> On Wed, Sep 29, 2010 at 04:19:04PM -0700, matt mooney wrote:
> > On 19:50 Wed 29 Sep , Sam Ravnborg wrote:
> > > On Wed, Sep 29, 2010 at 05:03:29PM +0200, Michal Marek wrote:
> > > > On 20.9.2010 08:33, matt mooney wrote:
> > > > > Change $(src) and $(obj) definitions to state the path as absolute and
> > > > > not relative.
> > > >
> > > > It _is_ a relative patch, AFAICS. What makes you think otherwise?
> > >
> > > With extenal modules $(src) and $(obj) are absolute - but in nomal
> > > use they are relative.
>
> Ah, I see. Then we should simply say "path", without any adjectives.
That may lead to people wondering what kind of path it is, or assumptions that
it is absolute due to being stated as such in modules.txt. Maybe a more detailed
explanation would suffice.
-mfm
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-02 4:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-20 6:33 [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt matt mooney
2010-09-29 15:03 ` Michal Marek
2010-09-29 17:50 ` Sam Ravnborg
2010-09-29 23:19 ` matt mooney
2010-10-01 20:56 ` Michal Marek
2010-10-02 4:14 ` matt mooney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox