From: Dan Carpenter <error27@gmail.com>
To: Rahul Ruikar <rahul.ruikar@gmail.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
nm127@freemail.hu, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND/PATCH] usb: gadget: goku_udc: Fix error path
Date: Mon, 4 Oct 2010 14:22:14 +0200 [thread overview]
Message-ID: <20101004122214.GA5692@bicker> (raw)
In-Reply-To: <1286135940-2364-1-git-send-email-rahul.ruikar@gmail.com>
On Mon, Oct 04, 2010 at 01:29:00AM +0530, Rahul Ruikar wrote:
> call put_device() when device_register() fails.
>
Sorry I didn't realize what you were trying to do here. This is not
correct at all.
The right thing is to fix device_register() to call put_device() itself.
It's a bit involved, because all the callers will need to be audited but
someone is working on this I think.
regards,
dan carpenter
next prev parent reply other threads:[~2010-10-04 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-03 19:59 [RESEND/PATCH] usb: gadget: goku_udc: Fix error path Rahul Ruikar
2010-10-04 12:22 ` Dan Carpenter [this message]
2010-10-04 13:24 ` Rahul Ruikar
2010-10-04 14:10 ` Dan Carpenter
2010-10-05 13:20 ` Greg KH
2010-10-05 16:53 ` Dan Carpenter
2010-10-05 16:55 ` [PATCH] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004122214.GA5692@bicker \
--to=error27@gmail.com \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm127@freemail.hu \
--cc=rahul.ruikar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox