Re: [RFC][PATCH] PM / Hibernate: Modify signature used to mark swap

[Pavel Machek <pavel@ucw.cz>]

> > > Index: linux-2.6/kernel/power/swap.c
> > > ===================================================================
> > > --- linux-2.6.orig/kernel/power/swap.c
> > > +++ linux-2.6/kernel/power/swap.c
> > > @@ -29,7 +29,7 @@
> > >
> > >   #include "power.h"
> > >
> > > -#define SWSUSP_SIG	"S1SUSPEND"
> > > +#define HIBERNATE_SIG	"LINHIB0001"
> > >
> > >   /*
> > >    *	The swap map is a data structure used for keeping track of each page
> > > @@ -195,7 +195,7 @@ static int mark_swapfiles(struct swap_ma
> > >   	if (!memcmp("SWAP-SPACE",swsusp_header->sig, 10) ||
> > >   	    !memcmp("SWAPSPACE2",swsusp_header->sig, 10)) {
> > >   		memcpy(swsusp_header->orig_sig,swsusp_header->sig, 10);
> > 
> > if no compression
> > 
> > > -		memcpy(swsusp_header->sig,SWSUSP_SIG, 10);
> > 
> > else
> > 
> > > +		memcpy(swsusp_header->sig, HIBERNATE_SIG, 10);
> > 
> > ??
> 
> I thought about that, but we'll need to drop the old signature when the image
> format changes (I think it will after your patch series) anyway.  And the
> benefit is not really worth it IMO (it only affects people using the in-kernel
> hibernation on x86-64).
> 

ACK. Lets keep this simple.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html