From: Rusty Russell <rusty@rustcorp.com.au>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: lkml <linux-kernel@vger.kernel.org>, "Tejun Heo" <tj@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Am��rico Wang" <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH resend] Update num_symtab, symtab and strtab right after setup of core_num_syms, core_symtab and core_strtab.
Date: Tue, 5 Oct 2010 10:39:27 +1030 [thread overview]
Message-ID: <201010051039.28412.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20100928010628.GA6923@localhost.localdomain>
On Tue, 28 Sep 2010 10:36:28 am Hu Tao wrote:
> symtab/strtab refer to memory that will be vfreed when load_module() is
> done. So update them early.
I don't think so. See layout_symtab which moves these into the init
section of the module.
Your change would make us unable to see init section symbols; if you
crash during module init, you really want to see these symbols.
Hope that helps,
Rusty.
prev parent reply other threads:[~2010-10-05 0:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 1:06 [PATCH resend] Update num_symtab, symtab and strtab right after setup of core_num_syms, core_symtab and core_strtab Hu Tao
2010-09-28 6:01 ` Hu Tao
2010-10-05 0:09 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010051039.28412.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=hutao@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox