Re: [PATCH] USB: misc: Add N-trig firmware driver

[Greg KH <greg@kroah.com>]

On Tue, Oct 05, 2010 at 06:59:43AM +0000, Micki Balanga wrote:
> 
> 
> > -----Original Message-----
> > From: Jiri Kosina [mailto:jkosina@suse.cz]
> > Sent: Monday, October 04, 2010 2:58 PM
> > To: Greg KH
> > Cc: Micki Balanga; gregkh@suse.de; jim.collar@eqware.net; linux-
> > usb@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH] USB: misc: Add N-trig firmware driver
> > 
> > On Sun, 3 Oct 2010, Greg KH wrote:
> > 
> > > >
> > >
> > > Can you please attach this in a non-base64 format so it can be
> > properly
> > > reviewed, and then, applied if applicable?
> > >
> > > Note, please run the patch through the scripts/checkpatch.pl tool
> > first
> > > before sending it out, so we don't just say the same things it finds
> > :)
> > 
> > As we already have HID driver for n-trig, could this whole thing
> > perhaps
> > be made part of it?
> > 
> > --
> > Jiri Kosina
> > SUSE Labs, Novell Inc.
> 
> The driver communicates with the bulk in/out endpoint. 

Why does it have to be a driver at all?  Why can't you just use libusb
or usbfs to implement this?

> It was written as a standalone module, because it does not use any HID
> subsystem services, and to ensure that the HID driver would not be too
> complex. 
> 
> The driver has been tested over several weeks at our company.
> The  patch was prepared and checked using the Checkpatch utility.

You might want to check that last step, it didn't seem to work properly
as the patch you sent could not be applied, due to it being base64
encoded :)

thanks,

greg k-h