public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: akpm@linux-foundation.org
Cc: mm-commits@vger.kernel.org, jslaby@suse.cz,
	a.p.zijlstra@chello.nl, tglx@linutronix.de,
	linux-kernel@vger.kernel.org
Subject: Re: + softirq-cleanup-preempt-check.patch added to -mm tree
Date: Tue, 5 Oct 2010 21:38:33 +0200	[thread overview]
Message-ID: <20101005193833.GA16493@elte.hu> (raw)
In-Reply-To: <201010051905.o95J5BrS013873@imap1.linux-foundation.org>


* akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:

> +static inline void softirq_preempt_check(struct softirq_action *h,
> +		int prev_count)

unnecessary linebreak.

> +{
> +	if (unlikely(prev_count != preempt_count())) {

should be something like:

	if (prev_count == preempt_count())
		return;

then the rest will look cleaner as well.

> +		printk(KERN_ERR "huh, entered softirq %td %s %pf with preempt_count %08x, exited with %08x?\n",

Could be pr_err().

> +			softirq_preempt_check(h, prev_count);

Please put 'debug' in the function name as i suggested - that way people 
will only read it if they are interested in debug checks.

softirq_debug_check() would be perfect. (which might even grow new 
checks in the future)

Thanks,

	Ingo

       reply	other threads:[~2010-10-05 19:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201010051905.o95J5BrS013873@imap1.linux-foundation.org>
2010-10-05 19:38 ` Ingo Molnar [this message]
2010-10-05 21:04   ` + softirq-cleanup-preempt-check.patch added to -mm tree Jiri Slaby
2010-10-09 16:15     ` Peter Zijlstra
2010-10-20  9:33       ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101005193833.GA16493@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox