From: Dan Carpenter <error27@gmail.com>
To: Tracey Dent <tdent48227@gmail.com>
Cc: greg@kroah.com, abbotti@mev.co.uk, fmhess@users.sourceforge.net,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that checkpatch.pl has 4 warnings and 0 errors
Date: Wed, 6 Oct 2010 06:48:47 +0200 [thread overview]
Message-ID: <20101006044847.GC5409@bicker> (raw)
In-Reply-To: <1286326843-6170-7-git-send-email-tdent48227@gmail.com>
On Tue, Oct 05, 2010 at 09:00:22PM -0400, Tracey Dent wrote:
> @@ -118,7 +118,8 @@ int comedi_device_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> for (driv = comedi_drivers; driv; driv = driv->next) {
> if (!try_module_get(driv->module)) {
> printk
> - (KERN_INFO "comedi: failed to increment module count, skipping\n");
> + (KERN_INFO "comedi: failed to increment \
> + module count, skipping\n");
This screws up the output that gets printed for the user. It happens
again below several times.
Also it's best to not break up string literals across lines because then
someone can't do a: grep "failed to increment module count". For these
cases it's better to go over 80 characters and make grep work.
regards,
dan carpenter
> continue;
> }
> if (driv->num_names) {
> @@ -206,8 +207,9 @@ int comedi_driver_unregister(struct comedi_driver *driver)
> if (dev->attached && dev->driver == driver) {
> if (dev->use_count)
> printk
> - (KERN_WARNING "BUG! detaching device with use_count=%d\n",
> - dev->use_count);
> + (KERN_WARNING "BUG! detaching device \
> + with use_count=%d\n",
> + dev->use_count);
> comedi_device_detach(dev);
> }
> mutex_unlock(&dev->mutex);
> @@ -647,7 +649,8 @@ unsigned comedi_buf_write_free(struct comedi_async *async, unsigned int nbytes)
> if ((int)(async->buf_write_count + nbytes -
> async->buf_write_alloc_count) > 0) {
> printk
> - (KERN_INFO "comedi: attempted to write-free more bytes than have been write-allocated.\n");
> + (KERN_INFO "comedi: attempted to write-free more \
> + bytes than have been write-allocated.\n");
> nbytes = async->buf_write_alloc_count - async->buf_write_count;
> }
> async->buf_write_count += nbytes;
> --
> 1.7.3.1.50.g1e633
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-10-06 4:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 1:00 [PATCH 01/28] Staging: comedi: comedi.h: Edit file so cleanpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 02/28] Staging: comedi: comedi_compat32.c: Edit file so that checkpatch.pl " Tracey Dent
2010-10-06 1:00 ` [PATCH 03/28] Staging: comedi: comedi_compat32.h: " Tracey Dent
2010-10-06 1:00 ` [PATCH 04/28] Staging: comedi: comedidev.h: " Tracey Dent
2010-10-06 1:00 ` [PATCH 05/28] Staging: comedi: comedi_fops.c: Edit file so that checkpatch.pl has 1 warnings and 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 06/28] Staging: comedi: comedilib.h: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that checkpatch.pl has 4 warnings and 0 errors Tracey Dent
2010-10-06 4:48 ` Dan Carpenter [this message]
2010-10-06 17:54 ` David Daney
2010-10-06 1:00 ` [PATCH 08/28] Staging: comedi: proc.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 09/28] Staging: comedi: range.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 10/28] Staging: comedi: kcomedilib: kcomedilib_main.c: " Tracey Dent
2010-10-06 4:44 ` Dan Carpenter
2010-10-06 1:00 ` [PATCH 11/28] Staging: comedi: drivers: 8253.h: " Tracey Dent
2010-10-06 1:00 ` [PATCH 12/28] Staging: comedi: drivers: 8255.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 13/28] Staging: comedi: drivers: 8255.h: " Tracey Dent
2010-10-06 1:00 ` [PATCH 14/28] Staging: comedi: drivers: adl_pci2608.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 15/28] Staging: comedi: drivers: adl_pci7230.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 16/28] Staging: comedi: drivers: adl_pci7296.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 17/28] Staging: comedi: drivers: adl_pci7432.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 18/28] Staging: comedi: drivers: adl_pci8164.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 19/28] Staging: comedi: drivers: adl_pci9111.c: Edit file so that checkpatch.pl has 30 warnings and 3 errors Tracey Dent
2010-10-06 4:34 ` Dan Carpenter
2010-10-06 1:00 ` [PATCH 20/28] Staging: comedi: drivers: adl_pci9118.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 21/28] Staging: comedi: drivers: adq12b.c: Edit file so that checkpatch.pl has 0 errors and 2 warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 22/28] Staging: comedi: drivers: adv_pci1710.c: Edit file so that checkpatch.pl complains a little less Tracey Dent
2010-10-06 1:00 ` [PATCH 23/28] Staging: comedi: drivers: adv_pci1723.c: Edit file so that checkpatch.pl has 0 warnings and 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 24/28] Staging: comedi: drivers: adv_pci_dio.c: Edit file so that checkpatch.pl has 3 warnings and 1 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 25/28] Staging: comedi: drivers: aio_aio12_8.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 26/28] Staging: comedi: drivers: aio_iiro_16.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 27/28] Staging: comedi: drivers: am9513.h: " Tracey Dent
2010-10-06 1:00 ` [PATCH 28/28] Staging: comedi: drivers: amcc_s5933.h: Edit file so that checkpatch.pl has 2 warnings and 0 errors Tracey Dent
2010-10-06 1:50 ` [PATCH 01/28] Staging: comedi: comedi.h: Edit file so cleanpatch.pl has 0 errors and warnings Greg KH
2010-10-06 2:01 ` T Dent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006044847.GC5409@bicker \
--to=error27@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=fmhess@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox