Re: [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that checkpatch.pl has 4 warnings and 0 errors

David Daney
2010-10-06T17:54:13Z

On 10/05/2010 06:00 PM, Tracey Dent wrote:
> Changed a few lines that made checkpatch.pl complain. Could not get ever warning but
> I got it down to to just 4, WARNING: line over 80 characters.

The overall goal is to improve the code, not placate checkpatch.pl

[...]
> printk
> - (KERN_WARNING "BUG! detaching device with use_count=%d\n",
> - dev->use_count);
> + (KERN_WARNING "BUG! detaching device \
> + with use_count=%d\n",
> + dev->use_count);

Is that really an improvement?

And even if it were, is that really how strings should be split up?

Hint:
pr_warning("BUG! detaching device with use_count=%d\n",
dev->use_count);

David Daney