From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932612Ab0JFHrc (ORCPT ); Wed, 6 Oct 2010 03:47:32 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:43825 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932492Ab0JFHr2 (ORCPT ); Wed, 6 Oct 2010 03:47:28 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=roCaIFGwHRP3Qx70YVWDYdaKLOWGwhWICpoH41dOUn/eQV9zTUpn8gX4BQouqmUjGd 1um6zw2mIkyBc3DL+xBXZbVwiz7R6/VSsbHdNjcEXLj6aN4G+UW/llHHb2b1HxLGKySD gjpb0NISqpMpGN3TK0DlhKyHMSY9y0uP9iNRk= Date: Wed, 6 Oct 2010 09:47:14 +0200 From: Dan Carpenter To: Armin Schindler Cc: Karsten Keil , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] eicon: make buffer larger Message-ID: <20101006074714.GE5409@bicker> Mail-Followup-To: Dan Carpenter , Armin Schindler , Karsten Keil , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20101004192459.GE5692@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 06, 2010 at 09:25:44AM +0200, Armin Schindler wrote: > On Mon, 4 Oct 2010, Dan Carpenter wrote: >> In diva_mnt_add_xdi_adapter() we do this: >> strcpy (clients[id].drvName, tmp); >> strcpy (clients[id].Dbg.drvName, tmp); >> >> The "clients[id].drvName" is a 128 character buffer and >> "clients[id].Dbg.drvName" was originally a 16 character buffer but I've >> changed it to 128 as well. We don't actually use 128 characters but we >> do use more than 16. > > I don't see any reason for that change. The driver names here do not use > more than 16 characters and when filled, the length is checked anyway. > Please avoid changing the size of that structure. > drivers/isdn/hardware/eicon/debug.c diva_mnt_add_xdi_adapter() 874 sprintf (tmp, "ADAPTER:%d SN:%u-%d", 12345678 90123 45 67 That's a minimum 17 characters. 875 (int)logical, 876 serial & 0x00ffffff, 877 (byte)(((serial & 0xff000000) >> 24) + 1)); 878 } else { 879 sprintf (tmp, "ADAPTER:%d SN:%u", (int)logical, serial); 880 } regards, dan carpenter > Armin