From: Sascha Hauer <s.hauer@pengutronix.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/4] dmaengine: Add Freescale i.MX1/21/27 DMA driver
Date: Wed, 6 Oct 2010 10:24:22 +0200 [thread overview]
Message-ID: <20101006082422.GT28242@pengutronix.de> (raw)
In-Reply-To: <4CABB1B9.4080002@intel.com>
On Tue, Oct 05, 2010 at 04:16:09PM -0700, Dan Williams wrote:
>> + unsigned int channel;
>> + unsigned int imxdma_channel;
>> +
>> + enum dma_data_direction direction;
>
> Why does the channel have a direction isn't that a function of the
> transaction? It's also unused.
>
>> + enum dma_slave_buswidth word_size;
>> + dma_addr_t bd_phys;
>
> unused?
>
>> + unsigned long flags;
>
> unused?
Sorry, it seems I was a bit too fast posting it. I'll send an updated
version.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2010-10-06 8:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 13:56 dmaengine patches Sascha Hauer
2010-09-30 13:56 ` [PATCH 1/4] dmaengine: add possibility for cyclic transfers Sascha Hauer
2010-09-30 13:56 ` [PATCH 2/4] dmaengine: add wrapper functions for device control functions Sascha Hauer
2010-09-30 13:56 ` [PATCH 3/4] dmaengine: Add Freescale i.MX SDMA support Sascha Hauer
2010-10-08 0:14 ` Dan Williams
2010-09-30 13:56 ` [PATCH 4/4] dmaengine: Add Freescale i.MX1/21/27 DMA driver Sascha Hauer
[not found] ` <AANLkTikaAuBe=ef3vnt_xV0At4ZQbNsD4rFqtLF4R+0+@mail.gmail.com>
2010-10-05 10:06 ` Sascha Hauer
2010-10-05 15:20 ` Linus Walleij
2010-10-05 23:16 ` Dan Williams
2010-10-06 8:24 ` Sascha Hauer [this message]
2010-10-06 8:25 ` [PATCH 4/4 v2] " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006082422.GT28242@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=dan.j.williams@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox