From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757321Ab0JFMO3 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Oct 2010 08:14:29 -0400
Received: from mail-wy0-f174.google.com ([74.125.82.174]:56706 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756008Ab0JFMO1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Oct 2010 08:14:27 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:mail-followup-to:references
         :mime-version:content-type:content-disposition:in-reply-to
         :user-agent;
        b=jZ+fYqm8MIWLVlUwFHbxVBZWArxF34NOEtX5AquZw+4khotsKDAz8EQJGTcKdB5e6p
         xuP2OmtqlVJNrHrqpazhYACg/Dvk1+Su7HwPdJovTwGG4wQqWxG7uF94WP25E7x0QfsS
         KgDSqVBOH2WaUW6TBAhzD+BTusNpXzn2wE7ks=
Date: Wed, 6 Oct 2010 14:11:20 +0200
From: Dan Carpenter <error27@gmail.com>
To: Armin Schindler <armin@melware.de>
Cc: Karsten Keil <isdn@linux-pingi.de>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] eicon: make buffer larger
Message-ID: <20101006121119.GA11681@bicker>
Mail-Followup-To: Dan Carpenter <error27@gmail.com>,
	Armin Schindler <armin@melware.de>,
	Karsten Keil <isdn@linux-pingi.de>, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <20101004192459.GE5692@bicker> <alpine.DEB.2.00.1010060923120.29107@justus.melware.de> <20101006074714.GE5409@bicker> <alpine.DEB.2.00.1010061019480.29404@justus.melware.de> <20101006083117.GF5409@bicker> <alpine.DEB.2.00.1010061043550.29582@justus.melware.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.00.1010061043550.29582@justus.melware.de>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 06, 2010 at 10:44:47AM +0200, Armin Schindler wrote:
>>   927    strcpy (clients[id].drvName,     tmp);
>>   928    strcpy (clients[id].Dbg.drvName, tmp);
>>                               ^
>>                    this buffer is only 16 chars
>
> Now I understand. You are right. So the fix would be to change these  
> strcpy() to e.g. strncpy() or similar.
>

We need more than 16 characters to store the information.  What is the
problem with just making the buffer larger?

regards,
dan carpenter

> Armin