From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757292Ab0JFMgA (ORCPT ); Wed, 6 Oct 2010 08:36:00 -0400 Received: from db3ehsobe001.messaging.microsoft.com ([213.199.154.139]:59993 "EHLO DB3EHSOBE001.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755667Ab0JFMf6 (ORCPT ); Wed, 6 Oct 2010 08:35:58 -0400 X-SpamScore: -18 X-BigFish: VPS-18(zzbb2cK1432N98dN4015Lzz1202hzz8275bh8275dhz32i2a8h61h) X-Spam-TCS-SCL: 0:0 X-WSS-ID: 0L9VCAV-02-B5U-02 X-M-MSG: Date: Wed, 6 Oct 2010 14:35:21 +0200 From: Robert Richter To: Matt Fleming CC: Peter Zijlstra , Will Deacon , Paul Mundt , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , Ingo Molnar , Frederic Weisbecker , Arnaldo Carvalho de Melo , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Deng-Cheng Zhu , Grant Likely Subject: Re: [PATCH 1/7] perf: Add helper function to return number of counters Message-ID: <20101006123521.GM13563@erda.amd.com> References: <20101006121410.GK13563@erda.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20101006121410.GK13563@erda.amd.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Reverse-DNS: ausb3extmailp02.amd.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.10.10 14:14:10, Robert Richter wrote: > On 04.10.10 16:44:19, Matt Fleming wrote: > > The number of counters for the registered pmu is needed in a few places > > so provide a helper function that returns this number. > > > > Signed-off-by: Matt Fleming > > Tested-by: Will Deacon > > --- > > arch/arm/kernel/perf_event.c | 6 ++++++ > > arch/arm/oprofile/common.c | 31 ++++++++++++++++++------------- > > arch/sh/kernel/perf_event.c | 9 +++++++++ > > include/linux/perf_event.h | 1 + > > 4 files changed, 34 insertions(+), 13 deletions(-) > > diff --git a/arch/arm/oprofile/common.c b/arch/arm/oprofile/common.c > > index d660cb8..23f18a0 100644 > > --- a/arch/arm/oprofile/common.c > > +++ b/arch/arm/oprofile/common.c > > @@ -43,7 +43,7 @@ static DEFINE_MUTEX(op_arm_mutex); > > > > static struct op_counter_config *counter_config; > > static struct perf_event **perf_events[nr_cpumask_bits]; > > -static int perf_num_counters; > > +static int perf_nr_counters; Matt, as we will have one more version with this patch set, please use num_counters instead of perf_nr_counters. The same name is used also for x86. Thanks, -Robert > > > > /* > > * Overflow callback for oprofile. -- Advanced Micro Devices, Inc. Operating System Research Center