From: Jason Baron <jbaron@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
mingo@elte.hu, mathieu.desnoyers@polymtl.ca, hpa@zytor.com,
tglx@linutronix.de, andi@firstfloor.org, roland@redhat.com,
rth@redhat.com, fweisbec@gmail.com, avi@redhat.com,
davem@davemloft.net, vgoyal@redhat.com, sam@ravnborg.org,
tony@bakeyournoodle.com, ddaney@caviumnetworks.com,
linux-kernel@vger.kernel.org, 2nddept-manager@sdl.hitachi.co.jp
Subject: Re: [PATCH 1/5] jump label: fix module __init section race
Date: Wed, 6 Oct 2010 11:41:41 -0400 [thread overview]
Message-ID: <20101006154140.GA2941@redhat.com> (raw)
In-Reply-To: <1286370051.6750.180.camel@gandalf.stny.rr.com>
On Wed, Oct 06, 2010 at 09:00:50AM -0400, Steven Rostedt wrote:
> On Sat, 2010-10-02 at 17:58 +0900, Masami Hiramatsu wrote:
>
> > > +static void remove_module_init(struct module *mod)
> >
> > Hi Jason,
> >
> > Just a comment, I prefer remove_jump_label_module_init() than this name,
> > because remove_module_init is too general.
>
> This is probably not too big of a deal since it is static, but the name
> change may make it easier for etags and ctags users.
>
> Jason, are you OK if I pull in this patch and make the change myself?
>
> -- Steve
>
fine with me. I had a more specific function name and then shortened it
because it seemed too long, either way is fine with me.
thanks,
-Jason
next prev parent reply other threads:[~2010-10-06 15:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 21:23 [PATCH 0/5] jump label: core updates Jason Baron
2010-10-01 21:23 ` [PATCH 1/5] jump label: fix module __init section race Jason Baron
2010-10-02 8:58 ` Masami Hiramatsu
2010-10-06 13:00 ` Steven Rostedt
2010-10-06 15:41 ` Jason Baron [this message]
2010-10-06 15:46 ` Steven Rostedt
2010-10-07 1:56 ` Masami Hiramatsu
2010-10-30 10:39 ` [tip:perf/urgent] jump label: Fix " tip-bot for Jason Baron
2010-10-01 21:23 ` [PATCH 2/5] jump label: Fix deadlock b/w jump_label_mutex vs. text_mutex Jason Baron
2010-10-02 9:00 ` Masami Hiramatsu
2010-10-30 10:40 ` [tip:perf/urgent] " tip-bot for Jason Baron
2010-10-01 21:23 ` [PATCH 3/5] jump label: add register_jump_label_key/unregister_jump_label_key Jason Baron
2010-10-01 21:23 ` [PATCH 4/5] jump label: move jump table to r/w section Jason Baron
2010-10-01 21:24 ` [PATCH 5/5] jump label: add docs Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006154140.GA2941@redhat.com \
--to=jbaron@redhat.com \
--cc=2nddept-manager@sdl.hitachi.co.jp \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=davem@davemloft.net \
--cc=ddaney@caviumnetworks.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rth@redhat.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=tony@bakeyournoodle.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox