From: Andrew Morton <akpm@linux-foundation.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memblock: Fix big size with find_region()
Date: Wed, 6 Oct 2010 15:45:03 -0700 [thread overview]
Message-ID: <20101006154503.db30e742.akpm@linux-foundation.org> (raw)
In-Reply-To: <4CACF453.5020205@zytor.com>
On Wed, 06 Oct 2010 15:12:35 -0700
"H. Peter Anvin" <hpa@zytor.com> wrote:
> On 10/06/2010 02:06 PM, Andrew Morton wrote:
> >
> > This seems rather odd. If some caller is passing in size>end then that
> > caller is buggy isn't it? A memory block which ends at 0x1000 and has
> > a size of 0x2000 is nonsensical.
> >
> > So shouldn't we at leat emit a warning so tht the offending caller can
> > be found and fixed?
> >
>
> I don't think this is necessarily a bug in the caller -- it just
> indicates that it has a request that is impossible to fulfill -- but
> that can happen for a lot of other reasons.
>
> Keep in mind that the range and the size will typically come from
> different origins. As such, it's not clear to me that this is something
> that requires printing a specific error message for any more than any
> other allocation failure, but perhaps you disagree?
>
whomeidunno. The question is "is this something we want to know
about". If it's a BIOS/acpi/whatever error then I'd think "yes",
because that would then lead to useful kernel workarounds or BIOS
updates?
next prev parent reply other threads:[~2010-10-06 22:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 8:47 [PATCH] memblock: Fix big size with find_region() Yinghai Lu
2010-10-06 21:06 ` Andrew Morton
2010-10-06 21:55 ` Yinghai Lu
2010-10-06 22:12 ` H. Peter Anvin
2010-10-06 22:45 ` Andrew Morton [this message]
2010-10-06 22:47 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006154503.db30e742.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox