From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759247Ab0JFPvP (ORCPT ); Wed, 6 Oct 2010 11:51:15 -0400 Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:54425 "EHLO TX2EHSOBE008.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757107Ab0JFPvM (ORCPT ); Wed, 6 Oct 2010 11:51:12 -0400 X-SpamScore: -14 X-BigFish: VPS-14(zzbb2cK1432N98dNzz1202hzzz32i2a8h43h61h) X-Spam-TCS-SCL: 0:0 X-WSS-ID: 0L9VLBZ-02-7SN-02 X-M-MSG: Date: Wed, 6 Oct 2010 17:50:26 +0200 From: Robert Richter To: Paul Mundt CC: Peter Zijlstra , Matt Fleming , Will Deacon , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , Ingo Molnar , Frederic Weisbecker , Arnaldo Carvalho de Melo , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Deng-Cheng Zhu , Grant Likely Subject: Re: [PATCH 2/7] perf: New helper function for pmu name Message-ID: <20101006155026.GT13563@erda.amd.com> References: <59a8e68894a2e755232189abbe9b1a3b892e309c.1286222593.git.matt@console-pimps.org> <20101006122736.GL13563@erda.amd.com> <20101006123950.GA29118@linux-sh.org> <20101006131825.GO13563@erda.amd.com> <20101006133041.GA29273@linux-sh.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20101006133041.GA29273@linux-sh.org> User-Agent: Mutt/1.5.20 (2009-06-14) X-Reverse-DNS: unknown Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.10.10 09:30:41, Paul Mundt wrote: > On Wed, Oct 06, 2010 at 03:18:25PM +0200, Robert Richter wrote: > > So, I am also fine with implementing a generic perf_pmu_name() for sh > > and then derive the oprofile cpu_type string from it in the oprofile > > code. > > > Again, this is unacceptable. Paul, maybe I misunderstood you, but isn't this you preferred solution? We make perf_pmu_name() part of the generic i/f and then derive the oprofile name from the pmu name provided by perf. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center