* [RESEND/PATCH] usb: gadget: dummy_hcd: Fix error path
@ 2010-10-02 15:11 Rahul Ruikar
2010-10-02 15:13 ` Rahul Ruikar
0 siblings, 1 reply; 6+ messages in thread
From: Rahul Ruikar @ 2010-10-02 15:11 UTC (permalink / raw)
To: David Brownell, Greg Kroah-Hartman, Alan Stern
Cc: linux-usb, linux-kernel, Rahul Ruikar
In function dummy_udc_probe()
call put_device() when device_register() fails.
also usb_get_hcd() put before device_register() after review comment
from Alan Stern.
Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
---
drivers/usb/gadget/dummy_hcd.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index dc65462..9b30483 100644
--- a/drivers/usb/gadget/dummy_hcd.c
+++ b/drivers/usb/gadget/dummy_hcd.c
@@ -874,6 +874,8 @@ static int dummy_udc_probe (struct platform_device *pdev)
struct dummy *dum = the_controller;
int rc;
+ usb_get_hcd(dummy_to_hcd(dum));
+
dum->gadget.name = gadget_name;
dum->gadget.ops = &dummy_ops;
dum->gadget.is_dualspeed = 1;
@@ -885,10 +887,10 @@ static int dummy_udc_probe (struct platform_device *pdev)
dum->gadget.dev.parent = &pdev->dev;
dum->gadget.dev.release = dummy_gadget_release;
rc = device_register (&dum->gadget.dev);
- if (rc < 0)
+ if (rc < 0) {
+ put_device(&dum->gadget.dev);
return rc;
-
- usb_get_hcd (dummy_to_hcd (dum));
+ }
platform_set_drvdata (pdev, dum);
rc = device_create_file (&dum->gadget.dev, &dev_attr_function);
--
1.7.2.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [RESEND/PATCH] usb: gadget: dummy_hcd: Fix error path
2010-10-02 15:11 [RESEND/PATCH] usb: gadget: dummy_hcd: Fix error path Rahul Ruikar
@ 2010-10-02 15:13 ` Rahul Ruikar
2010-10-06 20:23 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Rahul Ruikar @ 2010-10-02 15:13 UTC (permalink / raw)
To: David Brownell, Greg Kroah-Hartman, Alan Stern
Cc: linux-usb, linux-kernel, Rahul Ruikar
[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]
updated patch attached here.
- Rahul Ruikar
On 2 October 2010 20:41, Rahul Ruikar <rahul.ruikar@gmail.com> wrote:
> In function dummy_udc_probe()
> call put_device() when device_register() fails.
> also usb_get_hcd() put before device_register() after review comment
> from Alan Stern.
>
> Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
> ---
> drivers/usb/gadget/dummy_hcd.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
> index dc65462..9b30483 100644
> --- a/drivers/usb/gadget/dummy_hcd.c
> +++ b/drivers/usb/gadget/dummy_hcd.c
> @@ -874,6 +874,8 @@ static int dummy_udc_probe (struct platform_device *pdev)
> struct dummy *dum = the_controller;
> int rc;
>
> + usb_get_hcd(dummy_to_hcd(dum));
> +
> dum->gadget.name = gadget_name;
> dum->gadget.ops = &dummy_ops;
> dum->gadget.is_dualspeed = 1;
> @@ -885,10 +887,10 @@ static int dummy_udc_probe (struct platform_device *pdev)
> dum->gadget.dev.parent = &pdev->dev;
> dum->gadget.dev.release = dummy_gadget_release;
> rc = device_register (&dum->gadget.dev);
> - if (rc < 0)
> + if (rc < 0) {
> + put_device(&dum->gadget.dev);
> return rc;
> -
> - usb_get_hcd (dummy_to_hcd (dum));
> + }
>
> platform_set_drvdata (pdev, dum);
> rc = device_create_file (&dum->gadget.dev, &dev_attr_function);
> --
> 1.7.2.3
>
>
[-- Attachment #2: 0001-usb-gadget-dummy_hcd-Fix-error-path.patch --]
[-- Type: text/x-patch, Size: 1429 bytes --]
From 50883d4df7f36bf9b87c8836ebd7de15fc7ac900 Mon Sep 17 00:00:00 2001
From: Rahul Ruikar <rahul.ruikar@gmail.com>
Date: Sat, 2 Oct 2010 20:34:34 +0530
Subject: [RESEND/PATCH] usb: gadget: dummy_hcd: Fix error path
In function dummy_udc_probe()
call put_device() when device_register() fails.
also usb_get_hcd() put before device_register() after review comment
from Alan Stern.
Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
---
drivers/usb/gadget/dummy_hcd.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index dc65462..9b30483 100644
--- a/drivers/usb/gadget/dummy_hcd.c
+++ b/drivers/usb/gadget/dummy_hcd.c
@@ -874,6 +874,8 @@ static int dummy_udc_probe (struct platform_device *pdev)
struct dummy *dum = the_controller;
int rc;
+ usb_get_hcd(dummy_to_hcd(dum));
+
dum->gadget.name = gadget_name;
dum->gadget.ops = &dummy_ops;
dum->gadget.is_dualspeed = 1;
@@ -885,10 +887,10 @@ static int dummy_udc_probe (struct platform_device *pdev)
dum->gadget.dev.parent = &pdev->dev;
dum->gadget.dev.release = dummy_gadget_release;
rc = device_register (&dum->gadget.dev);
- if (rc < 0)
+ if (rc < 0) {
+ put_device(&dum->gadget.dev);
return rc;
-
- usb_get_hcd (dummy_to_hcd (dum));
+ }
platform_set_drvdata (pdev, dum);
rc = device_create_file (&dum->gadget.dev, &dev_attr_function);
--
1.7.2.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [RESEND/PATCH] usb: gadget: dummy_hcd: Fix error path
2010-10-02 15:13 ` Rahul Ruikar
@ 2010-10-06 20:23 ` Greg KH
2010-10-07 4:11 ` Rahul Ruikar
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2010-10-06 20:23 UTC (permalink / raw)
To: Rahul Ruikar
Cc: David Brownell, Greg Kroah-Hartman, Alan Stern, linux-usb,
linux-kernel
On Sat, Oct 02, 2010 at 08:43:44PM +0530, Rahul Ruikar wrote:
> updated patch attached here.
It's attached in base64 mode, sorry, I can't apply it. Please resend it
properly.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND/PATCH] usb: gadget: dummy_hcd: Fix error path
2010-10-06 20:23 ` Greg KH
@ 2010-10-07 4:11 ` Rahul Ruikar
0 siblings, 0 replies; 6+ messages in thread
From: Rahul Ruikar @ 2010-10-07 4:11 UTC (permalink / raw)
To: Greg KH
Cc: David Brownell, Greg Kroah-Hartman, Alan Stern, linux-usb,
linux-kernel
sent in another mail.
- Rahul Ruikar
On 7 October 2010 01:53, Greg KH <greg@kroah.com> wrote:
> On Sat, Oct 02, 2010 at 08:43:44PM +0530, Rahul Ruikar wrote:
>> updated patch attached here.
>
> It's attached in base64 mode, sorry, I can't apply it. Please resend it
> properly.
>
> greg k-h
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RESEND/PATCH] usb: gadget: dummy_hcd: Fix error path
@ 2010-10-07 4:10 Rahul Ruikar
2010-10-07 4:12 ` Rahul Ruikar
0 siblings, 1 reply; 6+ messages in thread
From: Rahul Ruikar @ 2010-10-07 4:10 UTC (permalink / raw)
To: David Brownell, Greg Kroah-Hartman, Alan Stern
Cc: linux-usb, linux-kernel, Rahul Ruikar
In function dummy_udc_probe()
call put_device() when device_register() fails.
also usb_get_hcd() put before device_register() after review comment
from Alan Stern.
Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
---
drivers/usb/gadget/dummy_hcd.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index dc65462..9b30483 100644
--- a/drivers/usb/gadget/dummy_hcd.c
+++ b/drivers/usb/gadget/dummy_hcd.c
@@ -874,6 +874,8 @@ static int dummy_udc_probe (struct platform_device *pdev)
struct dummy *dum = the_controller;
int rc;
+ usb_get_hcd(dummy_to_hcd(dum));
+
dum->gadget.name = gadget_name;
dum->gadget.ops = &dummy_ops;
dum->gadget.is_dualspeed = 1;
@@ -885,10 +887,10 @@ static int dummy_udc_probe (struct platform_device *pdev)
dum->gadget.dev.parent = &pdev->dev;
dum->gadget.dev.release = dummy_gadget_release;
rc = device_register (&dum->gadget.dev);
- if (rc < 0)
+ if (rc < 0) {
+ put_device(&dum->gadget.dev);
return rc;
-
- usb_get_hcd (dummy_to_hcd (dum));
+ }
platform_set_drvdata (pdev, dum);
rc = device_create_file (&dum->gadget.dev, &dev_attr_function);
--
1.7.2.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [RESEND/PATCH] usb: gadget: dummy_hcd: Fix error path
2010-10-07 4:10 Rahul Ruikar
@ 2010-10-07 4:12 ` Rahul Ruikar
0 siblings, 0 replies; 6+ messages in thread
From: Rahul Ruikar @ 2010-10-07 4:12 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, Rahul Ruikar, David Brownell, Alan Stern
Greg,
Kindly include this patch.
- Rahul Ruikar
On 7 October 2010 09:40, Rahul Ruikar <rahul.ruikar@gmail.com> wrote:
> In function dummy_udc_probe()
> call put_device() when device_register() fails.
> also usb_get_hcd() put before device_register() after review comment
> from Alan Stern.
>
> Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
> ---
> drivers/usb/gadget/dummy_hcd.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
> index dc65462..9b30483 100644
> --- a/drivers/usb/gadget/dummy_hcd.c
> +++ b/drivers/usb/gadget/dummy_hcd.c
> @@ -874,6 +874,8 @@ static int dummy_udc_probe (struct platform_device *pdev)
> struct dummy *dum = the_controller;
> int rc;
>
> + usb_get_hcd(dummy_to_hcd(dum));
> +
> dum->gadget.name = gadget_name;
> dum->gadget.ops = &dummy_ops;
> dum->gadget.is_dualspeed = 1;
> @@ -885,10 +887,10 @@ static int dummy_udc_probe (struct platform_device *pdev)
> dum->gadget.dev.parent = &pdev->dev;
> dum->gadget.dev.release = dummy_gadget_release;
> rc = device_register (&dum->gadget.dev);
> - if (rc < 0)
> + if (rc < 0) {
> + put_device(&dum->gadget.dev);
> return rc;
> -
> - usb_get_hcd (dummy_to_hcd (dum));
> + }
>
> platform_set_drvdata (pdev, dum);
> rc = device_create_file (&dum->gadget.dev, &dev_attr_function);
> --
> 1.7.2.3
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-07 4:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-02 15:11 [RESEND/PATCH] usb: gadget: dummy_hcd: Fix error path Rahul Ruikar
2010-10-02 15:13 ` Rahul Ruikar
2010-10-06 20:23 ` Greg KH
2010-10-07 4:11 ` Rahul Ruikar
-- strict thread matches above, loose matches on Subject: below --
2010-10-07 4:10 Rahul Ruikar
2010-10-07 4:12 ` Rahul Ruikar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox