From: Sonny Rao <sonnyrao@us.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Nishanth Aravamudan <nacc@us.ibm.com>,
miltonm@bga.com, Thomas Gleixner <tglx@linutronix.de>,
Ian Campbell <ian.campbell@citrix.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
linux-kernel@vger.kernel.org, sonnyrao@linux.vnet.ibm.com
Subject: Re: [RESEND PATCH 1/2] IRQ: use cpu_possible_mask rather than online_mask in setup_affinity
Date: Wed, 6 Oct 2010 16:02:36 -0500 [thread overview]
Message-ID: <20101006210236.GQ13726@us.ibm.com> (raw)
In-Reply-To: <1286017262.2144.90.camel@laptop>
On Sat, Oct 02, 2010 at 01:01:02PM +0200, Peter Zijlstra wrote:
> On Fri, 2010-10-01 at 14:26 -0700, Nishanth Aravamudan wrote:
> > The use of online_mask requires architecture code to be hotplug-aware to
> > account for IRQ round-robin'ing.
>
> Architectures that support hotplug should be hotplug aware, that's not
> too much to ask imho.
It seems like most architectures support HOTPLUG_CPU
a quick grep for HOTPLUG_CPU in arch shows:
arm
blackfin
ia64
m32r
mips
mn10300
parisc
powerpc
s390
sh
sparc
x86
also see my reply to Thomas -- it appears that many of the interrupt
controller implementations enforce only affinitizing to online cpus
The other point is, as this is generic code, it's making an assumption
that online cpus is the right mask to test against and we know of at
least one case where this isn't quite correct.
> > With user-driven dynamic SMT,
>
> What's that?
Well, that is basically a feature where we can use CPU hotplug to
force a particular mode on an SMT (hardware multithreaded) processor
The point here was really that on such multi-threaded processors -- which are
becoming more common -- cpu hotplug can potentially be used fairly
often.
Sonny
next prev parent reply other threads:[~2010-10-06 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 21:26 [RESEND PATCH 0/2] Fix IRQ round-robing w/o irqbalance on pseries Nishanth Aravamudan
2010-10-01 21:26 ` [RESEND PATCH 1/2] IRQ: use cpu_possible_mask rather than online_mask in setup_affinity Nishanth Aravamudan
2010-10-02 10:57 ` Thomas Gleixner
2010-10-06 20:55 ` Sonny Rao
2010-10-02 11:01 ` Peter Zijlstra
2010-10-06 21:02 ` Sonny Rao [this message]
2010-10-11 18:48 ` Peter Zijlstra
2010-10-11 19:52 ` Sonny Rao
2010-10-01 21:26 ` [RESEND PATCH 2/2] pseries/xics: use cpu_possible_mask rather than cpu_all_mask Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006210236.GQ13726@us.ibm.com \
--to=sonnyrao@us.ibm.com \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
--cc=nacc@us.ibm.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=peterz@infradead.org \
--cc=sonnyrao@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox