Re: [PATCH] ipc: initialize structure memory to zero for shmctl

Al Viro
2010-10-07T01:21:40Z

On Wed, Oct 06, 2010 at 05:10:31PM -0700, Kees Cook wrote:
> The old shm interface will leak a few bytes of stack contents. Explicitly
> initialize the structure to zero-fill the untouched fields.

Umm... I wonder if we ever have gaps in there; note that gaps between
the fields are _not_ initialized in compound literals. Yes, I realize
that it's a separate problem, but explicit memset() prior to initializations
of fields might be a better solution, covering both.