From: Greg KH <gregkh@suse.de>
To: Sameer Nanda <snanda@chromium.org>
Cc: lenb@kernel.org, stefan.bader@canonical.com,
brad.figg@canonical.com, apw@canonical.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: Read TSC upon resume
Date: Wed, 6 Oct 2010 19:19:59 -0700 [thread overview]
Message-ID: <20101007021959.GA7300@suse.de> (raw)
In-Reply-To: <1286406919-6236-1-git-send-email-snanda@chromium.org>
On Wed, Oct 06, 2010 at 04:15:19PM -0700, Sameer Nanda wrote:
> Read the TSC upon resuming and print it out. This is useful
> in helping figure out amount of time spent in the BIOS when
> resuming from suspend.
>
> Change-Id: I1d6a32bd62421becddecd152d561763e5f3e1101
What is this tag for? I don't think it matches anything the kernel
community wants, do you?
And are you always going to be printing this out? Why do we want to
know this every time?
> Signed-off-by: Sameer Nanda <snanda@chromium.org>
> ---
> drivers/acpi/sleep.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> index c0fed2e..f0588fa 100644
> --- a/drivers/acpi/sleep.c
> +++ b/drivers/acpi/sleep.c
> @@ -214,6 +214,7 @@ static int acpi_suspend_enter(suspend_state_t pm_state)
> acpi_status status = AE_OK;
> unsigned long flags = 0;
> u32 acpi_state = acpi_target_sleep_state;
> + u64 tsc;
>
> ACPI_FLUSH_CPU_CACHE();
>
> @@ -235,6 +236,9 @@ static int acpi_suspend_enter(suspend_state_t pm_state)
>
> case ACPI_STATE_S3:
> do_suspend_lowlevel();
> + rdtscll(tsc);
> + printk(KERN_INFO "TSC at resume: %llu\n",
> + (unsigned long long)tsc);
How long does this take, will it slow down resume?
thanks,
greg k-h
next prev parent reply other threads:[~2010-10-07 2:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 23:15 [PATCH] ACPI: Read TSC upon resume Sameer Nanda
2010-10-07 2:19 ` Greg KH [this message]
[not found] ` <AANLkTimE2h46iZkj_amvgUg5UwN9xjuwqdW5TB+XccYy@mail.gmail.com>
2010-10-07 17:46 ` Greg KH
2010-10-07 18:05 ` Sameer Nanda
2010-10-07 18:15 ` Greg KH
2010-10-07 21:44 ` Rafael J. Wysocki
2010-10-16 3:03 ` Koornstra, Reinoud
2010-10-18 2:41 ` Chen Gong
2010-10-07 17:58 ` Sameer Nanda
2010-10-07 19:59 ` Rafael J. Wysocki
2010-10-07 21:27 ` Sameer Nanda
2010-10-07 21:43 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101007021959.GA7300@suse.de \
--to=gregkh@suse.de \
--cc=apw@canonical.com \
--cc=brad.figg@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snanda@chromium.org \
--cc=stefan.bader@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox