From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756040Ab0JGHMe (ORCPT ); Thu, 7 Oct 2010 03:12:34 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:52924 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024Ab0JGHMd (ORCPT ); Thu, 7 Oct 2010 03:12:33 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=hnNfDrmPOrZMnFj6ybpJX5XcU0KM9YqTrLkXNHBxWp5X4r+eHIyDykSlnbxTpiSw2r iECEZH7Bnw+DvZcMkWYnt5DwVb7Q2DDlUr7pp21FNgb//Q+Ch7Qy4Yws5QWJf7LHLSFw kuTi+vbPjVMVkAexXz1PqsqYeWuVTEYupNUyY= Date: Thu, 7 Oct 2010 11:12:26 +0400 From: Anton Vorontsov To: Kumar Gala Cc: Andrew Morton , Scott Wood , Peter Tyser , linux-kernel@vger.kernel.org, Dave Jiang , linuxppc-dev@ozlabs.org, Doug Thompson Subject: Re: [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix) Message-ID: <20101007071226.GA32189@oksana.dev.rtsoft.ru> References: <20100715182507.GA3482@oksana.dev.rtsoft.ru> <20100716151224.21d499a3@schlenkerla.am.freescale.net> <20100721153933.64d02086.akpm@linux-foundation.org> <20100721182108.5a22c822@schlenkerla.am.freescale.net> <20100801105419.GA352@oksana.dev.rtsoft.ru> <5628792F-9A5F-4200-90B3-FB3939F02969@kernel.crashing.org> <20101007062909.GA27110@oksana.dev.rtsoft.ru> <0778A3B9-E242-4BCC-B318-154BE9ECB2C6@kernel.crashing.org> <4A00FECC-3840-45E1-AB2A-6BDBD0FE09E0@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4A00FECC-3840-45E1-AB2A-6BDBD0FE09E0@kernel.crashing.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 07, 2010 at 02:00:50AM -0500, Kumar Gala wrote: > > On Oct 7, 2010, at 1:37 AM, Kumar Gala wrote: > > >> @ -1125,7 +1128,10 @@ static struct of_device_id mpc85xx_mc_err_of_match[] = { > >> { .compatible = "fsl,mpc8569-memory-controller", }, > >> { .compatible = "fsl,mpc8572-memory-controller", }, > >> { .compatible = "fsl,mpc8349-memory-controller", }, > >> + { .compatible = "fsl,p1020-memory-controller", }, > >> + { .compatible = "fsl,p1021-memory-controller", }, > >> { .compatible = "fsl,p2020-memory-controller", }, > >> + { .compatible = "fsl,p4080-memory-controller", }, > > > > This line should be here ;) > > should NOT be here. Hm. Are you sure? I thought that only L2 cache controller is not applicable (and based on Scott's comment I removed the l2 cache compatible entry for p4080). But I guess memory-controller is somewhat similar to all other 85xx? If it's not, I can surely prepare a patch that removes p4080 entry. Thanks, -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2