Re: [PATCH 2/4] HWPOISON: Copy si_addr_lsb to user

Andi Kleen
2010-10-07T07:36:35Z

On Thu, Oct 07, 2010 at 03:31:31PM +0900, Hidetoshi Seto wrote:
> (2010/10/07 5:48), Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > The original hwpoison code added a new siginfo field si_addr_lsb to
> > pass the granuality of the fault address to user space. Unfortunately
> > this field was never copied to user space. Fix this here.
> >
> > I added explicit checks for the MCEERR codes to avoid having
> > to patch all potential callers to initialize the field.
>
> Now QEMU uses signalfd to catch the SIGBUS delivered to the
> main thread, so I think similar fix to copy lsb to user is
> required for signalfd too.

Good catch. I don't think qemu uses this today, but it should
be fixed there too for .37 at least.

-Andi