Re: [PATCH 3/4] HWPOISON: Report correct address granuality for AO huge page errors

Andi Kleen
2010-10-07T07:38:51Z

On Thu, Oct 07, 2010 at 09:31:20AM +0900, Naoya Horiguchi wrote:
> > @@ -198,7 +199,8 @@ static int kill_proc_ao(struct task_struct *t, unsigned long addr, int trapno,
> > #ifdef __ARCH_SI_TRAPNO
> > si.si_trapno = trapno;
> > #endif
> > - si.si_addr_lsb = PAGE_SHIFT;
> > + order = PageCompound(page) ? huge_page_order(page) : PAGE_SHIFT;
> ^^^^
> huge_page_order(page_hstate(page)) ?

Ok.

> > printk(KERN_ERR
> > "MCE %#lx: forcibly killing %s:%d because of failure to unmap corrupted page\n",
> > - pfn, tk->tsk->comm, tk->tsk->pid);
> > + pfn,
> > + tk->tsk->comm, tk->tsk->pid);
>
> What's the point of this change?

Probably left over from an earlier version; I will drop that hunk thanks.

-Andi
--
ak@linux.intel.com -- Speaking for myself only.