Re: [PATCH 2/4] HWPOISON: Copy si_addr_lsb to user

Naoya Horiguchi
2010-10-07T00:32:06Z

Just nitpicking...

> @@ -2215,6 +2215,14 @@ int copy_siginfo_to_user(siginfo_t __user *to, siginfo_t *from)
> #ifdef __ARCH_SI_TRAPNO
> err |= __put_user(from->si_trapno, &to->si_trapno);
> #endif
> +#ifdef BUS_MCEERR_AO
> + /*
^
trailing white space
> + * Other callers might not initialize the si_lsb field,
> + * so check explicitely for the right codes here.
^ ^^^^^^^^^^^
white space explicitly

> + */
> + if (from->si_code == BUS_MCEERR_AR || from->si_code == BUS_MCEERR_AO)
> + err |= __put_user(from->si_addr_lsb, &to->si_addr_lsb);
> +#endif
> break;
> case __SI_CHLD:
> err |= __put_user(from->si_pid, &to->si_pid);

Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

Thanks,
Naoya Horiguchi