From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933152Ab0JGOBh (ORCPT ); Thu, 7 Oct 2010 10:01:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30082 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933101Ab0JGOBe (ORCPT ); Thu, 7 Oct 2010 10:01:34 -0400 Date: Thu, 7 Oct 2010 10:01:12 -0400 From: Don Zickus To: Andi Kleen Cc: mingo@elte.hu, fweisbec@gmail.com, robert.richter@amd.com, gorcunov@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [RFC] arch generic way to trigger unknown NMIs Message-ID: <20101007140112.GN10663@redhat.com> References: <20101007030807.GA4076@redhat.com> <20101007072641.GE5010@basil.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101007072641.GE5010@basil.fritz.box> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 07, 2010 at 09:26:41AM +0200, Andi Kleen wrote: > > Having a regression test for this is good, but it would > be also good if it wasn't a private one but in some public > git repository. Yeah, I know. It isn't meant to be private, mostly glue logic to load this module using RedHat's internal test harness. Is there a more public place to add a test like this? I guess that would be LTP. Though last time I looked at LTP, all the tests are written in 'C' whereas I just cobbled together some shell scripts to configure kdump, load the module, panic, process the resulting vmcore to verify it panic'd for the right reason. > > > static struct jprobe lkdtm; > > @@ -340,6 +343,9 @@ static void lkdtm_do_action(enum ctype which) > > set_current_state(TASK_UNINTERRUPTIBLE); > > schedule(); > > break; > > + case NMI: > > + apic->send_IPI_allbutself(NMI_VECTOR); > > + break; > > case NONE: > > default: > > break; > > > > Anyone have any thoughts? Maybe there is an easier way? > > Do you really want the NMI on all CPUs - 1? Normally it's directed to > a single one. No I prefer a single one too, but there didn't seem to be a send_IPI_self() command, so I took the short route and sent it to everyone. :-( Cheers, Don > > -Andi