public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Wiese <aw-lkml@meterriblecrew.net>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Ciaran McCreesh <ciaran.mccreesh@googlemail.com>
Subject: fallocate() on XFS clobbers S*ID-bits
Date: Thu, 7 Oct 2010 20:34:19 +0200	[thread overview]
Message-ID: <20101007183418.GC5621@incendiary.meterriblecrew.net> (raw)

Hello.

I (with support from Cc'ed Ciaran) just noticed some odd behaviour with
fallocate() on XFS.  After open()ing some file and setting it S*ID via
fchmod(), S*ID bits vanish after calling fallocate() — as supposed to
for non-root users, but it also happens for root.

Is this intended behaviour or did we spot a bug here?

At least on ext2 it works as expected, thus I guess it's the latter one.

I'm running v2.6.35.7 vanilla-kernel, but diffing fs/xfs to master
doesn't seem to address this issue.

HAND & LG -- aw
-- 
This signature is intentionally left blank.

             reply	other threads:[~2010-10-07 18:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-07 18:34 Andreas Wiese [this message]
2010-10-07 23:24 ` fallocate() on XFS clobbers S*ID-bits Dave Chinner
2010-10-08  9:26   ` Andreas Wiese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101007183418.GC5621@incendiary.meterriblecrew.net \
    --to=aw-lkml@meterriblecrew.net \
    --cc=ciaran.mccreesh@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox