From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752070Ab0JHDx2 (ORCPT ); Thu, 7 Oct 2010 23:53:28 -0400 Received: from imr3.ericy.com ([198.24.6.13]:43696 "EHLO imr3.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295Ab0JHDx1 (ORCPT ); Thu, 7 Oct 2010 23:53:27 -0400 Date: Thu, 7 Oct 2010 20:52:48 -0700 From: Guenter Roeck To: Chen Gong CC: "lm-sensors@lm-sensors.org" , "JBeulich@novell.com" , "linux-kernel@vger.kernel.org" Subject: Re: [1/2] hwmon: uniform the init style of pkgtemp Message-ID: <20101008035248.GA23368@ericsson.com> References: <1285480800-14558-2-git-send-email-gong.chen@linux.intel.com> <20101002032603.GA25998@ericsson.com> <4CAE930D.2040601@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4CAE930D.2040601@linux.intel.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 07, 2010 at 11:42:05PM -0400, Chen Gong wrote: > 于 10/2/2010 11:26 AM, Guenter Roeck 写道: > > On Sun, Sep 26, 2010 at 05:59:59AM -0000, Chen Gong wrote: > >> pkgtemp is derived from coretemp, so some reasonable > >> logics should be applied onto pkgtemp, too. Such as > >> the init logic here. > >> > >> Signed-off-by: Chen Gong > >> Acked-by: Jan Beulich > >> > > Hi, > > > > this patch, when applied with CONFIG_HOTPLUG_CPU undefined, causes a compile failure > > because it tries to access pkgtemp_cpu_notifier which is not defined in this case. > > > > For that reason, I have removed the patch from the list of applied patches for -next. > > Please re-submit a version which compiles for all combinations of HOTPLUG_CPU and SMP > > defined/undefined. > > > > Thanks, > > Guenter > > > Sorry for late. I just come back from my holiday. If only this one patch > is applied, it is broken, but it will be OK after these 2 patches are > applied. I tested the patches when CONFIG_SMP is undefined, it does be Each patch by itself must be compilable, otherwise we break the ability to bisect. Not a good idea. > broken again. My suggestion is adding a macro definiton in the pkgtemp.c > like "#include ". If it is doable, I will re-post a new patch > series I assume you mean to add the include directive. Yes, that should do it, but please make sure that it compiles. Thanks, Guenter