From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754188Ab0JHH1s (ORCPT ); Fri, 8 Oct 2010 03:27:48 -0400 Received: from bld-mail17.adl2.internode.on.net ([150.101.137.102]:44519 "EHLO mail.internode.on.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753709Ab0JHH1r (ORCPT ); Fri, 8 Oct 2010 03:27:47 -0400 Date: Fri, 8 Oct 2010 18:27:41 +1100 From: Dave Chinner To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/18] fs: keep inode with backing-dev Message-ID: <20101008072741.GP4681@dastard> References: <1286515292-15882-1-git-send-email-david@fromorbit.com> <1286515292-15882-4-git-send-email-david@fromorbit.com> <20101008070154.GB23595@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101008070154.GB23595@lst.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 08, 2010 at 03:01:54AM -0400, Christoph Hellwig wrote: > On Fri, Oct 08, 2010 at 04:21:17PM +1100, Dave Chinner wrote: > > From: Nick Piggin > > > > Having inode on writeback lists of a different bdi than > > inode->i_mapping->backing_dev_info makes it very difficult to do > > per-bdi locking of the writeback lists. Add functions to move these > > inodes over when the mapping backing dev is changed. > > > > Also, rename i_mapping.backing_dev_info to i_mapping.a_bdi while we're > > here. Succinct is nice, and it catches conversion errors. > > NAK. This is fixed by my patch to always use s_bdi for writeback > purposed that hit Linus' tree two days ago. Great. I'll drop it from the series then. Cheers, Dave. -- Dave Chinner david@fromorbit.com