From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755264Ab0JHHz1 (ORCPT ); Fri, 8 Oct 2010 03:55:27 -0400 Received: from canuck.infradead.org ([134.117.69.58]:50281 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753378Ab0JHHzZ (ORCPT ); Fri, 8 Oct 2010 03:55:25 -0400 Date: Fri, 8 Oct 2010 03:55:24 -0400 From: Christoph Hellwig To: Dave Chinner Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 16/18] fs: Make iunique independent of inode_lock Message-ID: <20101008075524.GB30902@infradead.org> References: <1286515292-15882-1-git-send-email-david@fromorbit.com> <1286515292-15882-17-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1286515292-15882-17-git-send-email-david@fromorbit.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by canuck.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + hlist_bl_for_each_entry(inode, node, &b->head, i_hash) { > + if (inode->i_ino == ino && inode->i_sb == sb) { wouldn't it be more natural to test the sb first here? Otherwise looks good, Reviewed-by: Christoph Hellwig