From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755986Ab0JHISp (ORCPT ); Fri, 8 Oct 2010 04:18:45 -0400 Received: from canuck.infradead.org ([134.117.69.58]:33032 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755640Ab0JHISo (ORCPT ); Fri, 8 Oct 2010 04:18:44 -0400 Date: Fri, 8 Oct 2010 04:18:43 -0400 From: Christoph Hellwig To: Dave Chinner Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/18] fs: Protect inode->i_state with th einode->i_lock Message-ID: <20101008081843.GB17577@infradead.org> References: <1286515292-15882-1-git-send-email-david@fromorbit.com> <1286515292-15882-15-git-send-email-david@fromorbit.com> <20101008074932.GC24089@infradead.org> <20101008080428.GW4681@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101008080428.GW4681@dastard> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by canuck.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Ah, done thinking now! I was so the i_state field had been set > before the inode was added to various lists and potentially > accessable to other threads. I should probably add a comment to that > effect, right? Yes, please.