Re: [PATCH 07/18] exofs: use iput() for inode reference count decrements

Nick Piggin
2010-10-16T07:56:54Z

On Fri, Oct 08, 2010 at 04:21:21PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Direct modification of the inode reference count is a no-no. Convert
> the exofs decrements to call iput() instead of acting directly on
> i_count.

Could this go to exofs maintainer and get merged as a bugfix?

>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/exofs/inode.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c
> index b631ff3..0fb4d4c 100644
> --- a/fs/exofs/inode.c
> +++ b/fs/exofs/inode.c
> @@ -1101,7 +1101,7 @@ static void create_done(struct exofs_io_state *ios, void *p)
>
> set_obj_created(oi);
>
> - atomic_dec(&inode->i_count);
> + iput(inode);
> wake_up(&oi->i_wq);
> }
>