Re: [PATCH 02/18] fs: Convert nr_inodes and nr_unused to per-cpu counters

Christoph Hellwig
2010-10-08T07:01:11Z

On Fri, Oct 08, 2010 at 04:21:16PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The number of inodes allocated does not need to be tied to the
> addition or removal of an inode to/from a list. If we are not tied
> to a list lock, we could update the counters when inodes are
> initialised or destroyed, but to do that we need to convert the
> counters to be per-cpu (i.e. independent of a lock). This means that
> we have the freedom to change the list/locking implementation
> without needing to care about the counters.
>
> Based on a patch originally from Eric Dumazet.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good except for a spurious whitespace change in inode_init_early.

Reviewed-by: Christoph Hellwig <hch@lst.de>