Re: [PATCH 11/18] fs: Introduce per-bucket inode hash locks

Christoph Hellwig
2010-10-08T07:33:08Z

On Fri, Oct 08, 2010 at 04:21:25PM +1100, Dave Chinner wrote:
> From: Nick Piggin <npiggin@suse.de>
>
> Protect the inod hash with a single lock is not scalable. Convert

s/inod/inode/

> p = &root->inode_tree.rb_node;
> parent = NULL;
>
> - if (hlist_unhashed(&inode->i_hash))
> + if (hlist_bl_unhashed(&inode->i_hash))

Maybe introduce an inode_unhashed helper for this check which we're
doing in quite a lot of places?

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>