Re: [PATCH 10/18] fs: Factor inode hash operations into functions

Christoph Hellwig
2010-10-08T07:29:49Z

On Fri, Oct 08, 2010 at 04:21:24PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Before replacing the inode hash locking with a more scalable
> mechanism, factor the removal of the inode from the hashes rather
> than open coding it in several places.
>
> Based on a patch originally from Nick Piggin.

Looks good as an equal transformation, but what code is doing with
remove_inode_hash looks really buggy. It's doing a re-hash of a live
inode which is probably causing enough problems by itself, but should
at least have locks for it. Anyway, that's something for the coda folks
to sort out.

Reviewed-by: Christoph Hellwig <hch@lst.de>