Re: [PATCH 16/18] fs: Make iunique independent of inode_lock

Dave Chinner
2010-10-08T08:07:02Z

On Fri, Oct 08, 2010 at 03:55:24AM -0400, Christoph Hellwig wrote:
> > + hlist_bl_for_each_entry(inode, node, &b->head, i_hash) {
> > + if (inode->i_ino == ino && inode->i_sb == sb) {
>
> wouldn't it be more natural to test the sb first here?

Maybe, but I think an inode number match is less likely, so the
order it currently does the check results in less code being
executed on misses. I'll have a look at the rest of the code and do
whatever order they do.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com