Re: [PATCH 13/18] fs: split locking of inode writeback and LRU lists

Christoph Hellwig
2010-10-16T16:20:23Z

On Sat, Oct 16, 2010 at 06:57:13PM +1100, Nick Piggin wrote:
> > That needs some documentation both in the changelog and in the code
> > I think.
>
> This is another instance where the irregular i_lock locking is making
> these little subtleties to the locking. I think that is actually much
> worse for maintainence/complexity than a few trylocks which can be
> mostly removed with rcu anyway (which are obvious because of the well
> documented lock order).

Care to explain why? The I_FREEING and co checks are how we do things
all over the icache for a long time. They are perfectly easy to
understand concept. What I asked Dave about is documenting why he
changed things here.