Re: [PATCH 09/18] fs: rework icount to be a locked variable

Christoph Hellwig
2010-10-08T13:53:10Z

On Fri, Oct 08, 2010 at 09:15:49PM +1100, Dave Chinner wrote:
> > You are overdoing the information hiding here; _way_ too many small
> > functions that don't buy you anything so far, AFAICS.
>
> See akpm's comments on the previous version of the series.

It's one persons opinion. I tend to disagree with lots of it. iref
is a good new helper for filesystems to use, but for the unlocked
read it's reather pointless. iref_locked is even more pointless -
it's only used in core fs code (fs/inode.c, fs/fs-writeback.c,
fs/drop_caches.c, fs/notify/inode_mark.c and fs/quota/dquot.c) and
an opencoded increment would be a lot more readable.