From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Robert Richter <robert.richter@amd.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] apic, x86: Use BIOS settings for IBS and MCE threshold interrupt LVT offsets
Date: Fri, 8 Oct 2010 22:27:13 +0400 [thread overview]
Message-ID: <20101008182713.GA5780@lenovo> (raw)
In-Reply-To: <20101008102115.GG13563@erda.amd.com>
On Fri, Oct 08, 2010 at 12:21:15PM +0200, Robert Richter wrote:
> On 08.10.10 05:37:24, Cyrill Gorcunov wrote:
> > On Fri, Oct 8, 2010 at 1:24 PM, Robert Richter <robert.richter@amd.com> wrote:
> > ...
> > >> > + } else if (lvt_off != offset) {
> > >>
> > >> Could we put explicit type specificator here? For better readbility.
> > >> ...
> > >
> > > Cyrill,
> > >
> > > Do you mean an explicit type cast here, or something else?
> > >
> >
> > Yeah, explicit type cast (not a big deal though since at moment
> > of course nothing can fire in this snippet, but I think for future
> > modifications better to have explicit cast).
>
> Hmm, don't think this is really necessary. As an alternative we could
> make variable offset an int too and then do an explicit cast when
> calling setup_APIC_eilvt().
>
> But I rather tend to leave it as it is.
Well, I don't insist at all. Lets leave it as is.
Cyrill
next prev parent reply other threads:[~2010-10-08 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 10:27 [PATCH 0/2] apic, x86: Use BIOS settings to setup AMD EILVT APIC registers Robert Richter
2010-10-06 10:27 ` [PATCH 1/2] apic, x86: Check if EILVT APIC registers are available (AMD only) Robert Richter
2010-10-20 5:01 ` [tip:irq/core] " tip-bot for Robert Richter
2010-10-06 10:27 ` [PATCH 2/2] apic, x86: Use BIOS settings for IBS and MCE threshold interrupt LVT offsets Robert Richter
2010-10-06 19:41 ` Cyrill Gorcunov
2010-10-08 9:24 ` Robert Richter
2010-10-08 9:37 ` Cyrill Gorcunov
2010-10-08 10:21 ` Robert Richter
2010-10-08 18:27 ` Cyrill Gorcunov [this message]
2010-10-20 5:01 ` [tip:irq/core] " tip-bot for Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008182713.GA5780@lenovo \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox