From: Grant Likely <grant.likely@secretlab.ca>
To: David Miller <davem@davemloft.net>
Cc: dilinger@queued.net, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, sam@ravnborg.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 1/2 v2] of: move phandle/ihandle into types.h and export to userspace
Date: Fri, 8 Oct 2010 12:27:45 -0600 [thread overview]
Message-ID: <20101008182745.GI3863@angua.secretlab.ca> (raw)
In-Reply-To: <20101008.104557.59696706.davem@davemloft.net>
On Fri, Oct 08, 2010 at 10:45:57AM -0700, David Miller wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
> Date: Fri, 8 Oct 2010 11:36:50 -0600
>
> > Weird. Yeah, no other platforms expect to get a phandle type
> > definition from the kernel headers. The only thing driving this
> > conversation is from arch/sparc/include/asm/Kbuild:
> >
> > header-y += openprom.h
>
> It was probably at one point for the sake of asm/openpromio.h but
> that header has no dependencies on openprom.h
>
> The only hit I can find in google code search, for non-kernel code, is
> the SILO bootloader.
>
> But that tree includes it's own copy of include/asm/openprom.h so
> the actual kernel copy isn't even used.
>
> I'd say we can stop exporting that header and also therefore not
> worry about making phandle_t visible to userspace.
Yay! That simplifies everything, and I believe it also means that the
phandle/ihandle definitions can remain where they currently are in
linux/of.h
Andres, can you post an updated series that includes removing
openprom.h from the header export list?
Thanks,
g.
next prev parent reply other threads:[~2010-10-08 18:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 7:43 [PATCH 1/2 v2] of: move phandle/ihandle into types.h and export to userspace Andres Salomon
2010-10-08 17:12 ` Grant Likely
2010-10-08 17:17 ` David Miller
2010-10-08 17:36 ` Grant Likely
2010-10-08 17:45 ` David Miller
2010-10-08 18:27 ` Grant Likely [this message]
2010-10-08 18:38 ` Andres Salomon
2010-10-08 18:34 ` [PATCH] sparc: stop exporting openprom.h header Andres Salomon
2010-10-08 18:52 ` David Miller
2010-10-08 19:00 ` Grant Likely
2010-10-08 19:02 ` David Miller
2010-10-08 21:34 ` Andres Salomon
2010-10-09 8:51 ` Grant Likely
2010-10-09 20:48 ` Andres Salomon
2010-10-10 5:13 ` Grant Likely
2010-10-10 7:19 ` Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008182745.GI3863@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dilinger@queued.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox