From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] mfd: Factor out WM831x I2C I/O from the core driver
Date: Fri, 8 Oct 2010 20:57:08 +0200 [thread overview]
Message-ID: <20101008185708.GA4989@excalibur.local> (raw)
In-Reply-To: <1286556780-5610-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Hello.
On Fri, 2010-10-08 at 09:52, Mark Brown wrote:
> In preparation for the addition of SPI support for the WM831x move the I2C
> specific code into a separate file with a separate Kconfig option so the
> I2C support can be excluded from the build.
The factored out file is missing here. Makefile has a reference for wm831x-i2c,
but you seemed to have forgotten to git add it.
> Also update the 1133-EV1 PMIC module support for SMDK6410 to use the new
> symbol.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> arch/arm/mach-s3c64xx/Kconfig | 1 +
> drivers/mfd/Kconfig | 14 +++--
> drivers/mfd/Makefile | 1 +
> drivers/mfd/wm831x-core.c | 138 +-------------------------------------
> include/linux/mfd/wm831x/core.h | 12 ++++
> 5 files changed, 27 insertions(+), 139 deletions(-)
regards
Stefan Schmidt
next prev parent reply other threads:[~2010-10-08 19:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 16:52 [PATCH 1/2] mfd: Factor out WM831x I2C I/O from the core driver Mark Brown
2010-10-08 16:52 ` [PATCH 2/2] mfd: Add WM831x SPI support Mark Brown
2010-10-08 18:57 ` Stefan Schmidt [this message]
2010-10-08 18:58 ` [PATCH 1/2] mfd: Factor out WM831x I2C I/O from the core driver Mark Brown
2010-10-19 9:38 ` Samuel Ortiz
-- strict thread matches above, loose matches on Subject: below --
2010-10-08 21:23 Mark Brown
2010-10-19 9:43 ` Samuel Ortiz
2010-10-19 11:15 ` Samuel Ortiz
2010-10-19 15:14 ` Mark Brown
2010-10-19 15:27 ` Samuel Ortiz
2010-10-19 17:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008185708.GA4989@excalibur.local \
--to=stefan@datenfreihafen.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox