From: Marcelo Tosatti <mtosatti@redhat.com>
To: Huang Ying <ying.huang@intel.com>
Cc: Avi Kivity <avi@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dean Nelson <dnelson@redhat.com>
Subject: Re: [PATCH 2/2] kvm, MCE, Send SRAR SIGBUS directly
Date: Fri, 8 Oct 2010 21:37:08 -0300 [thread overview]
Message-ID: <20101009003708.GA18859@amt.cnet> (raw)
In-Reply-To: <20101008202501.GA2291@amt.cnet>
On Fri, Oct 08, 2010 at 05:25:01PM -0300, Marcelo Tosatti wrote:
> On Fri, Oct 08, 2010 at 04:24:15PM +0800, Huang Ying wrote:
> > Originally, SRAR SIGBUS is sent to QEMU-KVM via touching the poisoned
> > page. But commit 96054569190bdec375fe824e48ca1f4e3b53dd36 prevents the
> > signal from being sent. So now the signal is sent via
> > force_sig_info_fault directly.
> >
> > Reported-by: Dean Nelson <dnelson@redhat.com>
> > Signed-off-by: Huang Ying <ying.huang@intel.com>
> > ---
> > arch/x86/include/asm/signal.h | 3 +++
> > arch/x86/kvm/mmu.c | 15 +++------------
> > arch/x86/mm/fault.c | 6 +++---
> > 3 files changed, 9 insertions(+), 15 deletions(-)
> >
> > static int kvm_handle_bad_page(struct kvm *kvm, gfn_t gfn, pfn_t pfn)
> > {
> > kvm_release_pfn_clean(pfn);
> > if (is_hwpoison_pfn(pfn)) {
> > - kvm_send_hwpoison_signal(kvm, gfn);
> > + force_sig_info_fault(SIGBUS, BUS_MCEERR_AR,
> > + gfn_to_hva(kvm, gfn), current);
> > return 0;
> > } else if (is_fault_pfn(pfn))
> > return -EFAULT;
>
> Better fill siginfo and use force_sig_info, which is already exported.
Thats wrong, its not exported. But there is no need to force delivery,
so i've changed it to use send_sig_info.
Applied the other patches, thanks.
next prev parent reply other threads:[~2010-10-09 1:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 8:24 [PATCH 2/2] kvm, MCE, Send SRAR SIGBUS directly Huang Ying
2010-10-08 20:25 ` Marcelo Tosatti
2010-10-09 0:37 ` Marcelo Tosatti [this message]
2010-10-09 0:48 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101009003708.GA18859@amt.cnet \
--to=mtosatti@redhat.com \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=dnelson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox