From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753809Ab0JKJSo (ORCPT ); Mon, 11 Oct 2010 05:18:44 -0400 Received: from db3ehsobe003.messaging.microsoft.com ([213.199.154.141]:26640 "EHLO DB3EHSOBE003.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753427Ab0JKJSm (ORCPT ); Mon, 11 Oct 2010 05:18:42 -0400 X-SpamScore: -10 X-BigFish: VPS-10(zzbb2cK1432N98dN4015L78fbpzz1202hzz8275dhz32i2a8h43h61h) X-Spam-TCS-SCL: 0:0 X-FB-SS: 0, X-WSS-ID: 0LA4CI9-01-C3D-02 X-M-MSG: Date: Mon, 11 Oct 2010 11:18:10 +0200 From: Robert Richter To: Peter Zijlstra CC: Matt Fleming , Will Deacon , Paul Mundt , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , Arnaldo Carvalho de Melo , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Deng-Cheng Zhu , Grant Likely Subject: Re: [PATCH 2/7] perf: New helper function for pmu name Message-ID: <20101011091809.GQ13563@erda.amd.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Reverse-DNS: unknown Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.10.10 20:46:17, Matt Fleming wrote: > Introduce perf_pmu_name() helper function that returns the name of the > pmu. This gives us a generic way to get the name of a pmu regardless of > how an architecture identifies it internally. > > Signed-off-by: Matt Fleming Peter, I need your ack here. Thanks, -Robert > --- > arch/sh/kernel/perf_event.c | 9 +++++++++ > include/linux/perf_event.h | 1 + > kernel/perf_event.c | 5 +++++ > 3 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/arch/sh/kernel/perf_event.c b/arch/sh/kernel/perf_event.c > index 2cb9ad5..55fe89b 100644 > --- a/arch/sh/kernel/perf_event.c > +++ b/arch/sh/kernel/perf_event.c > @@ -59,6 +59,15 @@ static inline int sh_pmu_initialized(void) > return !!sh_pmu; > } > > +const char *perf_pmu_name(void) > +{ > + if (!sh_pmu) > + return NULL; > + > + return sh_pmu->name; > +} > +EXPORT_SYMBOL_GPL(perf_pmu_name); > + > int perf_num_counters(void) > { > if (!sh_pmu) > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index 1a02192..33f08da 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -850,6 +850,7 @@ extern int perf_max_events; > extern const struct pmu *hw_perf_event_init(struct perf_event *event); > > extern int perf_num_counters(void); > +extern const char *perf_pmu_name(void); > extern void perf_event_task_sched_in(struct task_struct *task); > extern void perf_event_task_sched_out(struct task_struct *task, struct task_struct *next); > extern void perf_event_task_tick(struct task_struct *task); > diff --git a/kernel/perf_event.c b/kernel/perf_event.c > index db5b560..fc51268 100644 > --- a/kernel/perf_event.c > +++ b/kernel/perf_event.c > @@ -85,6 +85,11 @@ void __weak hw_perf_enable(void) { barrier(); } > > void __weak perf_event_print_debug(void) { } > > +extern __weak const char *perf_pmu_name(void) > +{ > + return "pmu"; > +} > + > static DEFINE_PER_CPU(int, perf_disable_count); > > void perf_disable(void) > -- > 1.7.1 > > -- Advanced Micro Devices, Inc. Operating System Research Center