From: "Michael S. Tsirkin" <mst@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org,
Maciej Sosnowski <maciej.sosnowski@intel.com>,
"David S. Miller" <davem@davemloft.net>
Cc: stable@kernel.org
Subject: [PATCH] dma: fix error handling on out of memory
Date: Mon, 11 Oct 2010 11:44:17 +0200 [thread overview]
Message-ID: <20101011094416.GA3771@redhat.com> (raw)
get_user_pages might return less pages than requested. If this happens
for the first iovec in dma_pin_iovec_pages, then nr_iovecs is 0 and so
dma_unpin_iovec_pages will not unpin any pages, leaking pinned memory.
A similar off by one would trigger for any of the following entries.
Fix by updating nr_iovecs and nr_pages in this case.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Error handling in dma_pin_iovec_pages still looks wrong to me. Am I
missing something? The following patch against 2.6.36-rc7 was under
some very light testing by me.
Thanks,
drivers/dma/iovlock.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/iovlock.c b/drivers/dma/iovlock.c
index bb48a57..21ed8f3 100644
--- a/drivers/dma/iovlock.c
+++ b/drivers/dma/iovlock.c
@@ -107,10 +107,16 @@ struct dma_pinned_list *dma_pin_iovec_pages(struct iovec *iov, size_t len)
NULL);
up_read(¤t->mm->mmap_sem);
- if (ret != page_list->nr_pages)
+ if (unlikely(ret < 0))
goto unpin;
local_list->nr_iovecs = i + 1;
+
+ if (unlikely(ret != page_list->nr_pages)) {
+ page_list->nr_pages = ret;
+ goto unpin;
+ }
+
}
return local_list;
--
MST
next reply other threads:[~2010-10-11 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 9:44 Michael S. Tsirkin [this message]
2010-10-14 0:10 ` [PATCH] dma: fix error handling on out of memory Dan Williams
2010-10-14 8:11 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011094416.GA3771@redhat.com \
--to=mst@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.sosnowski@intel.com \
--cc=stable@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox