public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext3: Return proper error code on ext3_fill_super()
Date: Mon, 11 Oct 2010 16:44:43 +0200	[thread overview]
Message-ID: <20101011144443.GD3830@quack.suse.cz> (raw)
In-Reply-To: <1286791686-2973-1-git-send-email-namhyung@gmail.com>

On Mon 11-10-10 19:08:06, Namhyung Kim wrote:
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
  Looks OK. Merged.

							Honza
> ---
>  fs/ext3/super.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 421fad7..75bbf77 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -1871,6 +1871,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
>  	if (sbi->s_group_desc == NULL) {
>  		ext3_msg(sb, KERN_ERR,
>  			"error: not enough memory");
> +		ret = -ENOMEM;
>  		goto failed_mount;
>  	}
>  
> @@ -1958,6 +1959,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
>  	}
>  	if (err) {
>  		ext3_msg(sb, KERN_ERR, "error: insufficient memory");
> +		ret = err;
>  		goto failed_mount3;
>  	}
>  
> -- 
> 1.7.0.4
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

      reply	other threads:[~2010-10-11 14:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11 10:08 [PATCH] ext3: Return proper error code on ext3_fill_super() Namhyung Kim
2010-10-11 14:44 ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101011144443.GD3830@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox