From: Jan Kara <jack@suse.cz>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext3: Use DIV_ROUND_UP() on group desc block counting
Date: Mon, 11 Oct 2010 16:45:30 +0200 [thread overview]
Message-ID: <20101011144529.GE3830@quack.suse.cz> (raw)
In-Reply-To: <1286793519-3774-1-git-send-email-namhyung@gmail.com>
On Mon 11-10-10 19:38:39, Namhyung Kim wrote:
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
OK. Merged.
Honza
> ---
> fs/ext3/super.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 75bbf77..3fce402 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -1864,8 +1864,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
> sbi->s_groups_count = ((le32_to_cpu(es->s_blocks_count) -
> le32_to_cpu(es->s_first_data_block) - 1)
> / EXT3_BLOCKS_PER_GROUP(sb)) + 1;
> - db_count = (sbi->s_groups_count + EXT3_DESC_PER_BLOCK(sb) - 1) /
> - EXT3_DESC_PER_BLOCK(sb);
> + db_count = DIV_ROUND_UP(sbi->s_groups_count, EXT3_DESC_PER_BLOCK(sb));
> sbi->s_group_desc = kmalloc(db_count * sizeof (struct buffer_head *),
> GFP_KERNEL);
> if (sbi->s_group_desc == NULL) {
> --
> 1.7.0.4
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2010-10-11 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 10:38 [PATCH] ext3: Use DIV_ROUND_UP() on group desc block counting Namhyung Kim
2010-10-11 14:45 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011144529.GE3830@quack.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox