Re: [PATCH -v3 3/6] x86, NMI, Rewrite NMI handler

Don Zickus
2010-10-11T20:35:48Z

On Mon, Oct 11, 2010 at 06:13:55PM +0200, Peter Zijlstra wrote:
> On Sat, 2010-10-09 at 14:49 +0800, Huang Ying wrote:
> > notify_die(DIE_NMI_IPI);
> > notify_die(DIE_NMI);
> > /* process io port 0x61 */
> > nmi_watchdog_touch();
> > unknown_nmi();
>
> Why keep NMI_IPI? What the heck is it for?
>
> I'd like to see:
>
> DIE_NMI
> DIE_NMI_UNKNOWN
>
> In DIE_NMI we walk the chain and deal with NMIs, in DIE_NMI_UNKNOWN we
> try to consume extra NMIs where possible (like the much discussed extra
> PMU interrupts).

Yeah, there was another much discussed thread about creating an NMI
notifier chain (instead of using the die_chain). And then re-arrange
handlers according to a priority scheme.

I wouldn't mind have Ingo commit most of this patchset to a temporary
work-in-progress branch and have us build more changes on top. A lot of
these changes are a good stepping stone towards simplifying things.

Cheers,
Don