Re: [PATCH -v3 5/6] x86, NMI, treat unknown NMI as hardware error

Alan Cox
2010-10-10T13:41:13Z

On Sat, 9 Oct 2010 14:49:46 +0800
Huang Ying <ying.huang@intel.com> wrote:

> In general, unknown NMI is used by hardware and firmware to notify
> fatal hardware errors to OS. So the Linux should treat unknown NMI as
> hardware error and go panic upon unknown NMI for better error
> containment.

Not entirely true. Older machines use NMI for all sorts of interesting
purposes. In particular many 486 laptops trigger NMI as part of power
manaagement, (Hence the choice of the dazed and confused message)

> But there are some broken hardware, which will generate unknown NMI
> not for hardware error. To support these machines, a white list

"Broken" is not the right term. There is no formal documentation about
such uses of NMI on older PC platforms that forbids such use. They may not
agree with your personal preferred behaviour.

> These systems are identified via the presentation of APEI HEST or
> some PCI ID of the host bridge. The PCI ID of host bridge instead of
> DMI ID is used, so that the checking can be done based on the platform
> type instead of motherboard. This should be simpler and sufficient.
>
> The method to identify the platforms is designed by Andi Kleen.

Why not make the new flag also a boot option so you can force it on for
platforms where we don't auto whitelist it.

Alan