From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932919Ab0JLPxA (ORCPT ); Tue, 12 Oct 2010 11:53:00 -0400 Received: from cpoproxy3-pub.bluehost.com ([67.222.54.6]:39925 "HELO cpoproxy3-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932907Ab0JLPw5 (ORCPT ); Tue, 12 Oct 2010 11:52:57 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org; h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=oRECAYw7J7qODk77n38h5IT8Po5kinfvch4XJjFm/KceGgY6DR+p/3LSa0x2fC8vC1JlkxTe1kAY5D8wT3iVRu7st7S1rXZedqOa+HyhveT/fos+DCLm+DKldvyiTO78; Date: Tue, 12 Oct 2010 08:56:31 -0700 From: Jesse Barnes To: Jason Wessel Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] drm,kdb,kms: Add an enter argument to mode_set_base_atomic() API Message-ID: <20101012085631.32b0aaab@jbarnes-desktop> In-Reply-To: <4CB482EC.7050800@windriver.com> References: <1286887801-8179-1-git-send-email-jason.wessel@windriver.com> <1286887801-8179-4-git-send-email-jason.wessel@windriver.com> <20101012083827.12b8ccce@jbarnes-desktop> <4CB482EC.7050800@windriver.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 67.174.193.198 authed with jbarnes@virtuousgeek.org} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Oct 2010 10:46:52 -0500 Jason Wessel wrote: > On 10/12/2010 10:38 AM, Jesse Barnes wrote: > > On Tue, 12 Oct 2010 07:49:59 -0500 > > Jason Wessel wrote: > > > > > >> Some devices such as the pre nv02 chips have enter and exit > >> constraints where hardware compression must be turned off and > >> re-enabled on resuming normal operations. > >> > >> This patch extends the mode_set_base_atomic() call to pass an argument > >> to indicate if this is an entry or an exit from an atomic kernel mode > >> set change. Individual drm drivers can properly save and restore > >> state accordingly. > >> > >> Signed-off-by: Jason Wessel > >> CC: Jesse Barnes > >> CC: David Airlie > >> CC: dri-devel@lists.freedesktop.org > >> --- > >> drivers/gpu/drm/drm_fb_helper.c | 5 +++-- > >> drivers/gpu/drm/i915/intel_display.c | 4 ++-- > >> drivers/gpu/drm/nouveau/nv04_crtc.c | 2 +- > >> drivers/gpu/drm/nouveau/nv50_crtc.c | 2 +- > >> drivers/gpu/drm/radeon/atombios_crtc.c | 2 +- > >> drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 2 +- > >> drivers/gpu/drm/radeon/radeon_mode.h | 4 ++-- > >> include/drm/drm_crtc_helper.h | 3 ++- > >> 8 files changed, 13 insertions(+), 11 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > >> index 6a5e403..625a2d5 100644 > >> --- a/drivers/gpu/drm/drm_fb_helper.c > >> +++ b/drivers/gpu/drm/drm_fb_helper.c > >> @@ -263,7 +263,8 @@ int drm_fb_helper_debug_enter(struct fb_info *info) > >> funcs->mode_set_base_atomic(mode_set->crtc, > >> mode_set->fb, > >> mode_set->x, > >> - mode_set->y); > >> + mode_set->y, > >> + 1); > >> > > > > An enum for the last arg would make this call much less mysterious. :) > > > > > Is there anything that is already predefined or would you prefer just > true or false? > > This could be changed to a bool because there are really only two > states, entering and exiting. If you provide some guidance on the > preferred naming, I can re-spin the patch. I was thinking: enum mode_set_atomic { ENTER_KDB, EXIT_KDB, }; or something similar (the name of the enum could probably be better). Just having a number or true/false always makes me have to check the function prototype. Having an enum means it's readable at the callsite. But this is really just a nitpick; bool args like this are a pet peeve of mine. :) -- Jesse Barnes, Intel Open Source Technology Center