public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: "Penttilä Mika" <mika.penttila@ixonos.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HWPOISON: Implement hwpoison-on-free for soft offlining
Date: Tue, 12 Oct 2010 16:30:22 +0200	[thread overview]
Message-ID: <20101012143022.GF20436@basil.fritz.box> (raw)
In-Reply-To: <1A61D8EA6755AF458F06EA669A4EC81815FDA736@JKLMAIL02.ixonos.local>

On Tue, Oct 12, 2010 at 02:23:15PM +0000, Penttilä Mika wrote:
> > >>  		bad_page(page);
> > >>  		return 1;
> > >>  	}
> > >
> > > And of course PAGE_FLAGS_CHECK_AT_FREE should include
> > > pahehwpoisononfree this to be effective
> > 
> > It is of course (__PG_HWPOISON_ON_FREE)
> > 
> Yes but it's not included in PAGE_FLAGS_CHECK_AT_FREE, if  I'm not missing something

#ifdef CONFIG_HWPOISON_ON_FREE
PAGEFLAG(HWPoisonOnFree, hwpoison_on_free)
TESTSCFLAG(HWPoisonOnFree, hwpoison_on_free)
#define __PG_HWPOISON_ON_FREE (1UL << PG_hwpoison_on_free)
#else
PAGEFLAG_FALSE(HWPoisonOnFree)
SETPAGEFLAG_NOOP(HWPoisonOnFree)
#define __PG_HWPOISON_ON_FREE 0
#endif

...

#define PAGE_FLAGS_CHECK_AT_FREE \
        (1 << PG_lru     | 1 << PG_locked    | \
         1 << PG_private | 1 << PG_private_2 | \
         1 << PG_buddy   | 1 << PG_writeback | 1 << PG_reserved | \
         1 << PG_slab    | 1 << PG_swapcache | 1 << PG_active | \
         1 << PG_unevictable | __PG_MLOCKED | __PG_HWPOISON | \
         __PG_HWPOISON_ON_FREE)


-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2010-10-12 14:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-12 12:38 [PATCH] HWPOISON: Implement hwpoison-on-free for soft offlining Penttilä Mika
2010-10-12 14:06 ` Andi Kleen
2010-10-12 14:23   ` Penttilä Mika
2010-10-12 14:30     ` Andi Kleen [this message]
2010-10-12 14:33       ` Penttilä Mika
  -- strict thread matches above, loose matches on Subject: below --
2010-10-06 22:09 RFC: Implement hwpoison on free " Andi Kleen
2010-10-06 22:09 ` [PATCH] HWPOISON: Implement hwpoison-on-free " Andi Kleen
2010-10-12 12:26   ` Wu Fengguang
2010-10-12 12:37     ` Andi Kleen
2010-10-12 12:41       ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101012143022.GF20436@basil.fritz.box \
    --to=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.penttila@ixonos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox