From: "John W. Linville" <linville@tuxdriver.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-wireless@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Ben Greear <greearb@candelatech.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath5k: fix build break from "ath5k: Print out opmode in debugfs"
Date: Tue, 12 Oct 2010 14:18:04 -0400 [thread overview]
Message-ID: <20101012181804.GC2403@tuxdriver.com> (raw)
In-Reply-To: <AANLkTi=Rj+hmYthVcwYksSxUqFF+117FxVvdnuDCLxVY@mail.gmail.com>
On Tue, Oct 12, 2010 at 11:13:31AM -0700, Linus Torvalds wrote:
> On Tue, Oct 12, 2010 at 7:53 AM, John W. Linville
> <linville@tuxdriver.com> wrote:
> >
> > Please don't make me commit such an ugly patch...
>
> Why don't you just create a dummy inline ath_opmode_to_string() that
> returns NULL in the non-debug case? The compiler will make the
> conditionals all go away, and it will end up being "UNKNOWN" which is
> just what you want. No?
Shhh! Your messing-up my manipulative mind games! :-)
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-10-12 18:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 5:35 linux-next: build failure after merge of the final tree (wireless tree related) Stephen Rothwell
2010-10-12 14:53 ` [PATCH] ath5k: fix build break from "ath5k: Print out opmode in debugfs" John W. Linville
2010-10-12 15:43 ` Joe Perches
2010-10-12 17:15 ` John W. Linville
2010-10-12 16:54 ` Bob Copeland
2010-10-12 17:42 ` Bob Copeland
2010-10-12 18:07 ` Joe Perches
2010-10-12 18:13 ` Linus Torvalds
2010-10-12 18:18 ` John W. Linville [this message]
2010-10-12 23:31 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012181804.GC2403@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).