From: Ralf Baechle <ralf@linux-mips.org>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: dediao@cisco.com, ddaney@caviumnetworks.com, dvomlehn@cisco.com,
sshtylyov@mvista.com, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] MIPS: HIGHMEM DMA on noncoherent MIPS32 processors
Date: Wed, 13 Oct 2010 08:53:47 +0100 [thread overview]
Message-ID: <20101013075346.GA24052@linux-mips.org> (raw)
In-Reply-To: <f3f140ca90dc9dac2f645748bc3a0150@localhost>
On Sat, Oct 09, 2010 at 06:53:42PM -0700, Kevin Cernekee wrote:
> [v3: Patch has been rebased against linux-queue.git, which uses the new
> dma-mapping-common.h API.]
>
> The MIPS DMA coherency functions do not work properly (i.e. kernel oops)
> when HIGHMEM pages are passed in as arguments. This patch uses the PPC
> approach of calling kmap_atomic() with IRQs disabled to temporarily map
> high pages, in order to flush them out to memory.
It's this disabling of interrupts which I don't like. It's easy to get
around it by having one kmap type for each of process, softirq and
interrupt context.
The good news is that Peter Zijlstra has rewritten kmap to make the need
for manually allocated kmap types go away and his patches are queued to
be merged for 2.6.37. So I'd like to put this patch on hold until after
his patches are merged.
Does your system have both highmem and cache aliases?
Ralf
next prev parent reply other threads:[~2010-10-13 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 1:53 [PATCH v3 2/2] MIPS: HIGHMEM DMA on noncoherent MIPS32 processors Kevin Cernekee
2010-10-13 7:53 ` Ralf Baechle [this message]
2010-10-13 18:01 ` Kevin Cernekee
2010-10-13 20:32 ` Nicolas Pitre
2010-11-07 18:27 ` Kevin Cernekee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013075346.GA24052@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=cernekee@gmail.com \
--cc=ddaney@caviumnetworks.com \
--cc=dediao@cisco.com \
--cc=dvomlehn@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox