From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752295Ab0JMKDj (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Oct 2010 06:03:39 -0400
Received: from mga03.intel.com ([143.182.124.21]:45742 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752193Ab0JMKDh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Oct 2010 06:03:37 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.57,324,1283756400"; 
   d="scan'208";a="335534056"
Date: Wed, 13 Oct 2010 10:11:58 +0100
From: Alan Cox <alan@linux.intel.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
        Matthew Garrett <mjg@redhat.com>, Alek Du <alek.du@intel.com>,
        platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] intel_pmic_gpio: fix off-by-one value range checking
Message-ID: <20101013101158.1ae2a583@linux.intel.com>
In-Reply-To: <1286531671.6060.1.camel@mola>
References: <1286531671.6060.1.camel@mola>
Organization: Intel
X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.9; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 08 Oct 2010 17:54:31 +0800
Axel Lin <axel.lin@gmail.com> wrote:

> In pmic_irq_type(), we use gpio as array index for trigger,
> thus the valid value range for gpio should be 0 .. NUM_GPIO - 1.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Agreed - thanks for spotting this.

Alan