From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Tom Zanussi <tzanussi@gmail.com>,
Masami Hiramatsu <mhiramat@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Robert Richter <robert.richter@amd.com>
Subject: Re: [RFC PATCH 3/9] perf: Add ability to dump part of the user stack
Date: Wed, 13 Oct 2010 17:01:16 +0200 [thread overview]
Message-ID: <20101013150102.GE5335@nowhere> (raw)
In-Reply-To: <1286954537.29097.59.camel@twins>
On Wed, Oct 13, 2010 at 09:22:17AM +0200, Peter Zijlstra wrote:
> On Wed, 2010-10-13 at 07:06 +0200, Frederic Weisbecker wrote:
> > +++ b/include/linux/perf_event.h
> > @@ -227,6 +227,12 @@ struct perf_event_attr {
> > __u32 bp_type;
> > __u64 bp_addr;
> > __u64 bp_len;
> > +
> > + __u64 __reserved_2;
> > + __u64 __reserved_3;
> > +
> > + __u32 ustack_dump_size;
> > + __u32 __reserved_4;
> > };
>
> Why add those two __u64 fields?
Because I suspect one day the breakpoint fields will need to be
extended. Some archs have quite fancy features for breakpoints
that include value comparison for example. So a field could be
used for the comparison operator and the other for the value
to be compared against.
next prev parent reply other threads:[~2010-10-13 15:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 5:06 [RFC] perf: Dwarf cfi based user callchains Frederic Weisbecker
2010-10-13 5:06 ` [RFC PATCH 1/9] uaccess: Make copy_from_user_nmi() globally available Frederic Weisbecker
2010-10-13 7:15 ` Peter Zijlstra
2010-10-13 14:47 ` Frederic Weisbecker
2010-10-13 20:43 ` Peter Zijlstra
2010-10-13 5:06 ` [RFC PATCH 2/9] perf: Add ability to dump user regs Frederic Weisbecker
2010-10-13 7:20 ` Peter Zijlstra
2010-10-13 14:56 ` Frederic Weisbecker
2010-10-13 14:58 ` Frederic Weisbecker
2010-10-14 11:06 ` Stephane Eranian
2010-10-14 11:20 ` Frederic Weisbecker
2010-10-15 8:39 ` Stephane Eranian
2010-10-15 22:58 ` Frederic Weisbecker
2010-10-17 10:07 ` Peter Zijlstra
2010-10-18 10:01 ` Stephane Eranian
2010-10-18 22:35 ` Frederic Weisbecker
2010-10-20 9:24 ` Stephane Eranian
2010-10-20 16:13 ` Frederic Weisbecker
2010-10-20 16:19 ` Peter Zijlstra
2010-10-13 5:06 ` [RFC PATCH 3/9] perf: Add ability to dump part of the user stack Frederic Weisbecker
2010-10-13 7:22 ` Peter Zijlstra
2010-10-13 15:01 ` Frederic Weisbecker [this message]
2010-10-13 5:06 ` [RFC PATCH 4/9] perf: Don't record frame pointer based user stacktraces if we dump stack and regs Frederic Weisbecker
2010-10-13 7:23 ` Peter Zijlstra
2010-10-13 15:02 ` Frederic Weisbecker
2010-10-16 0:19 ` Frederic Weisbecker
2010-10-13 5:06 ` [RFC PATCH 5/9] perf: Support for dwarf mode callchain on perf record Frederic Weisbecker
2010-10-13 5:06 ` [RFC PATCH 6/9] perf: Build with dwarf cfi Frederic Weisbecker
2010-10-13 5:06 ` [RFC PATCH 7/9] perf: Support for error passed over pointers Frederic Weisbecker
2010-10-13 5:07 ` [RFC PATCH 8/9] perf: Add libunwind dependency for dwarf cfi unwinding Frederic Weisbecker
2010-10-13 5:07 ` [RFC PATCH 9/9] perf: Support for dwarf cfi unwinding on post processing Frederic Weisbecker
2010-10-13 15:13 ` [RFC] perf: Dwarf cfi based user callchains Frank Ch. Eigler
2010-10-20 15:35 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013150102.GE5335@nowhere \
--to=fweisbec@gmail.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).