From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, h.mitake@gmail.com,
Vojtech Pavlik <vojtech@ucw.cz>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 1/2] lockdep: check the depth of subclass
Date: Wed, 13 Oct 2010 11:18:44 -0700 [thread overview]
Message-ID: <20101013181844.GA13094@core.coreip.homeip.net> (raw)
In-Reply-To: <4CB51922.2080405@dcl.info.waseda.ac.jp>
On Wed, Oct 13, 2010 at 11:27:46AM +0900, Hitoshi Mitake wrote:
> On 10/13/10 01:03, Dmitry Torokhov wrote:
> > On Tue, Oct 12, 2010 at 12:27:01PM +0200, Peter Zijlstra wrote:
> >> On Tue, 2010-10-05 at 18:01 +0900, Hitoshi Mitake wrote:
> >>> ---
> >>> drivers/input/mousedev.c | 2 +-
> >>> kernel/lockdep.c | 15 +++++++++++++++
> >>> 2 files changed, 16 insertions(+), 1 deletions(-)
> >>>
> >>> diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
> >>> index d528a2d..9897334 100644
> >>> --- a/drivers/input/mousedev.c
> >>> +++ b/drivers/input/mousedev.c
> >>> @@ -866,7 +866,7 @@ static struct mousedev
> *mousedev_create(struct input_dev *dev,
> >>> spin_lock_init(&mousedev->client_lock);
> >>> mutex_init(&mousedev->mutex);
> >>> lockdep_set_subclass(&mousedev->mutex,
> >>> - minor == MOUSEDEV_MIX ? MOUSEDEV_MIX : 0);
> >>> + minor == MOUSEDEV_MIX ? SINGLE_DEPTH_NESTING : 0);
> >>
> >> Ah good find.
> >>
> >
> > I'll pick up mousedev change for .37.
>
> Thanks a lot, Dmitry.
>
> Should I divide this patch into two for
> drivers/input/mousedev.c and kernel/lockdep.c?
> If you need, I'll resend second version.
No, thanks, I'll extract it on my end.
--
Dmitry
next prev parent reply other threads:[~2010-10-13 18:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 9:01 [PATCH 1/2] lockdep: check the depth of subclass Hitoshi Mitake
2010-10-05 9:01 ` [RFC PATCH 2/2] lockdep: caching subclasses Hitoshi Mitake
2010-10-12 10:36 ` Peter Zijlstra
2010-10-18 19:17 ` [tip:core/locking] lockdep: Add improved subclass caching tip-bot for Hitoshi Mitake
2010-10-12 10:27 ` [PATCH 1/2] lockdep: check the depth of subclass Peter Zijlstra
2010-10-12 16:03 ` Dmitry Torokhov
2010-10-13 2:27 ` Hitoshi Mitake
2010-10-13 18:18 ` Dmitry Torokhov [this message]
2010-10-13 2:26 ` Hitoshi Mitake
2010-10-13 7:33 ` Peter Zijlstra
2010-10-13 8:13 ` Hitoshi Mitake
2010-10-13 8:30 ` [PATCH v2] " Hitoshi Mitake
2010-10-13 8:48 ` Peter Zijlstra
2010-10-18 19:17 ` [tip:core/locking] lockdep: Check " tip-bot for Hitoshi Mitake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013181844.GA13094@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=fweisbec@gmail.com \
--cc=h.mitake@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mitake@dcl.info.waseda.ac.jp \
--cc=peterz@infradead.org \
--cc=vojtech@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox