* [PATCH] staging: octeon: Add Lanai board USB clock type @ 2010-10-11 10:09 Bernhard Walle 2010-10-11 16:53 ` David Daney 0 siblings, 1 reply; 8+ messages in thread From: Bernhard Walle @ 2010-10-11 10:09 UTC (permalink / raw) To: ddaney; +Cc: devel, linux-kernel Add the LANAI2 board to __cvmx_helper_board_usb_get_clock_type(). It also uses the USB_CLOCK_TYPE_CRYSTAL_12 clock. Signed-off-by: Bernhard Walle <walle@corscience.de> --- drivers/staging/octeon/cvmx-helper-board.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/octeon/cvmx-helper-board.c b/drivers/staging/octeon/cvmx-helper-board.c index 5793318..f8ae6b4 100644 --- a/drivers/staging/octeon/cvmx-helper-board.c +++ b/drivers/staging/octeon/cvmx-helper-board.c @@ -752,6 +752,7 @@ cvmx_helper_board_usb_clock_types_t __cvmx_helper_board_usb_get_clock_type(void) { switch (cvmx_sysinfo_get()->board_type) { case CVMX_BOARD_TYPE_BBGW_REF: + case CVMX_BOARD_TYPE_LANAI2_G: return USB_CLOCK_TYPE_CRYSTAL_12; } return USB_CLOCK_TYPE_REF_48; -- 1.7.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: octeon: Add Lanai board USB clock type 2010-10-11 10:09 [PATCH] staging: octeon: Add Lanai board USB clock type Bernhard Walle @ 2010-10-11 16:53 ` David Daney 2010-10-11 17:05 ` Bernhard Walle 0 siblings, 1 reply; 8+ messages in thread From: David Daney @ 2010-10-11 16:53 UTC (permalink / raw) To: Bernhard Walle; +Cc: devel, linux-kernel On 10/11/2010 03:09 AM, Bernhard Walle wrote: > Add the LANAI2 board to __cvmx_helper_board_usb_get_clock_type(). It > also uses the USB_CLOCK_TYPE_CRYSTAL_12 clock. > > Signed-off-by: Bernhard Walle<walle@corscience.de> > --- > drivers/staging/octeon/cvmx-helper-board.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) NAK. We don't currently support USB, so churning up this file doesn't help anything. If you are using an out-of-tree driver, you can keep this kind of tweak out-of-tree as well. David Daney > > diff --git a/drivers/staging/octeon/cvmx-helper-board.c b/drivers/staging/octeon/cvmx-helper-board.c > index 5793318..f8ae6b4 100644 > --- a/drivers/staging/octeon/cvmx-helper-board.c > +++ b/drivers/staging/octeon/cvmx-helper-board.c > @@ -752,6 +752,7 @@ cvmx_helper_board_usb_clock_types_t __cvmx_helper_board_usb_get_clock_type(void) > { > switch (cvmx_sysinfo_get()->board_type) { > case CVMX_BOARD_TYPE_BBGW_REF: > + case CVMX_BOARD_TYPE_LANAI2_G: > return USB_CLOCK_TYPE_CRYSTAL_12; > } > return USB_CLOCK_TYPE_REF_48; ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: octeon: Add Lanai board USB clock type 2010-10-11 16:53 ` David Daney @ 2010-10-11 17:05 ` Bernhard Walle 2010-10-11 17:13 ` David Daney 0 siblings, 1 reply; 8+ messages in thread From: Bernhard Walle @ 2010-10-11 17:05 UTC (permalink / raw) To: David Daney; +Cc: devel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 588 bytes --] Am 11.10.2010 18:53, schrieb David Daney: > On 10/11/2010 03:09 AM, Bernhard Walle wrote: >> Add the LANAI2 board to __cvmx_helper_board_usb_get_clock_type(). It >> also uses the USB_CLOCK_TYPE_CRYSTAL_12 clock. >> >> Signed-off-by: Bernhard Walle<walle@corscience.de> >> --- >> drivers/staging/octeon/cvmx-helper-board.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) > > NAK. > > We don't currently support USB, so churning up this file doesn't help > anything. Well, agreed, but why not removing that code entirely then? Regards, Bernhard [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 900 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: octeon: Add Lanai board USB clock type 2010-10-11 17:05 ` Bernhard Walle @ 2010-10-11 17:13 ` David Daney 2010-10-12 15:54 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: David Daney @ 2010-10-11 17:13 UTC (permalink / raw) To: Bernhard Walle; +Cc: devel, linux-kernel On 10/11/2010 10:05 AM, Bernhard Walle wrote: > Am 11.10.2010 18:53, schrieb David Daney: >> On 10/11/2010 03:09 AM, Bernhard Walle wrote: >>> Add the LANAI2 board to __cvmx_helper_board_usb_get_clock_type(). It >>> also uses the USB_CLOCK_TYPE_CRYSTAL_12 clock. >>> >>> Signed-off-by: Bernhard Walle<walle@corscience.de> >>> --- >>> drivers/staging/octeon/cvmx-helper-board.c | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> NAK. >> >> We don't currently support USB, so churning up this file doesn't help >> anything. > > Well, agreed, but why not removing that code entirely then? > That is the eventual plan. David Daney ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: octeon: Add Lanai board USB clock type 2010-10-11 17:13 ` David Daney @ 2010-10-12 15:54 ` Greg KH 2010-10-12 16:56 ` David Daney 0 siblings, 1 reply; 8+ messages in thread From: Greg KH @ 2010-10-12 15:54 UTC (permalink / raw) To: David Daney; +Cc: Bernhard Walle, devel, linux-kernel On Mon, Oct 11, 2010 at 10:13:37AM -0700, David Daney wrote: > On 10/11/2010 10:05 AM, Bernhard Walle wrote: >> Am 11.10.2010 18:53, schrieb David Daney: >>> On 10/11/2010 03:09 AM, Bernhard Walle wrote: >>>> Add the LANAI2 board to __cvmx_helper_board_usb_get_clock_type(). It >>>> also uses the USB_CLOCK_TYPE_CRYSTAL_12 clock. >>>> >>>> Signed-off-by: Bernhard Walle<walle@corscience.de> >>>> --- >>>> drivers/staging/octeon/cvmx-helper-board.c | 1 + >>>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> >>> NAK. >>> >>> We don't currently support USB, so churning up this file doesn't help >>> anything. >> >> Well, agreed, but why not removing that code entirely then? >> > > That is the eventual plan. Why not do that now? Or add USB support to the driver, but don't leave it in the in-kernel driver and expect users to know that this is something they shouldn't be doing. Also, why aren't you going to support the USB devices? What's wrong with that? thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: octeon: Add Lanai board USB clock type 2010-10-12 15:54 ` Greg KH @ 2010-10-12 16:56 ` David Daney 2010-10-13 16:39 ` Bernhard Walle 0 siblings, 1 reply; 8+ messages in thread From: David Daney @ 2010-10-12 16:56 UTC (permalink / raw) To: Greg KH; +Cc: Bernhard Walle, devel, linux-kernel On 10/12/2010 08:54 AM, Greg KH wrote: > On Mon, Oct 11, 2010 at 10:13:37AM -0700, David Daney wrote: >> On 10/11/2010 10:05 AM, Bernhard Walle wrote: >>> Am 11.10.2010 18:53, schrieb David Daney: >>>> On 10/11/2010 03:09 AM, Bernhard Walle wrote: >>>>> Add the LANAI2 board to __cvmx_helper_board_usb_get_clock_type(). It >>>>> also uses the USB_CLOCK_TYPE_CRYSTAL_12 clock. >>>>> >>>>> Signed-off-by: Bernhard Walle<walle@corscience.de> >>>>> --- >>>>> drivers/staging/octeon/cvmx-helper-board.c | 1 + >>>>> 1 files changed, 1 insertions(+), 0 deletions(-) >>>> >>>> NAK. >>>> >>>> We don't currently support USB, so churning up this file doesn't help >>>> anything. >>> >>> Well, agreed, but why not removing that code entirely then? >>> >> >> That is the eventual plan. > > Why not do that now? > If others want do submit patches that do that, I would not object. It is not currently my highest priority, so it may be a little while before I would get to it. > Or add USB support to the driver, but don't leave it in the in-kernel > driver and expect users to know that this is something they shouldn't be > doing. > > Also, why aren't you going to support the USB devices? I'm not sure where you got that idea. What I said was "We don't currently support USB...", this doesn't mean that we wouldn't like to eventually have support for it merged. > What's wrong with that? Nothing. You may recall that people are working on getting the driver merged: http://marc.info/?l=linux-usb&m=128648942928513 The path of least resistance is to let that patch get merged first, and then submit the necessary glue to hook it up to OCTEON parts that support it. David Daney ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: octeon: Add Lanai board USB clock type 2010-10-12 16:56 ` David Daney @ 2010-10-13 16:39 ` Bernhard Walle 2010-10-13 21:02 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Bernhard Walle @ 2010-10-13 16:39 UTC (permalink / raw) To: David Daney; +Cc: Greg KH, devel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 462 bytes --] Am 12.10.2010 18:56, schrieb David Daney: > On 10/12/2010 08:54 AM, Greg KH wrote: >> On Mon, Oct 11, 2010 at 10:13:37AM -0700, David Daney wrote: >>> >>> That is the eventual plan. >> >> Why not do that now? >> > > If others want do submit patches that do that, I would not object. It > is not currently my highest priority, so it may be a little while before > I would get to it. I sent a patch now that does this. Regards, Bernhard [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 900 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: octeon: Add Lanai board USB clock type 2010-10-13 16:39 ` Bernhard Walle @ 2010-10-13 21:02 ` Greg KH 0 siblings, 0 replies; 8+ messages in thread From: Greg KH @ 2010-10-13 21:02 UTC (permalink / raw) To: Bernhard Walle; +Cc: David Daney, devel, linux-kernel On Wed, Oct 13, 2010 at 06:39:50PM +0200, Bernhard Walle wrote: > Am 12.10.2010 18:56, schrieb David Daney: > > On 10/12/2010 08:54 AM, Greg KH wrote: > >> On Mon, Oct 11, 2010 at 10:13:37AM -0700, David Daney wrote: > >>> > >>> That is the eventual plan. > >> > >> Why not do that now? > >> > > > > If others want do submit patches that do that, I would not object. It > > is not currently my highest priority, so it may be a little while before > > I would get to it. > > I sent a patch now that does this. Great, I'll queue it up, thanks. greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-10-13 21:02 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-10-11 10:09 [PATCH] staging: octeon: Add Lanai board USB clock type Bernhard Walle 2010-10-11 16:53 ` David Daney 2010-10-11 17:05 ` Bernhard Walle 2010-10-11 17:13 ` David Daney 2010-10-12 15:54 ` Greg KH 2010-10-12 16:56 ` David Daney 2010-10-13 16:39 ` Bernhard Walle 2010-10-13 21:02 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox