Re: [PATCH] staging: octeon: Add Lanai board USB clock type

David Daney
2010-10-12T16:56:40Z

On 10/12/2010 08:54 AM, Greg KH wrote:
> On Mon, Oct 11, 2010 at 10:13:37AM -0700, David Daney wrote:
>> On 10/11/2010 10:05 AM, Bernhard Walle wrote:
>>> Am 11.10.2010 18:53, schrieb David Daney:
>>>> On 10/11/2010 03:09 AM, Bernhard Walle wrote:
>>>>> Add the LANAI2 board to __cvmx_helper_board_usb_get_clock_type(). It
>>>>> also uses the USB_CLOCK_TYPE_CRYSTAL_12 clock.
>>>>>
>>>>> Signed-off-by: Bernhard Walle<walle@corscience.de>
>>>>> ---
>>>>> drivers/staging/octeon/cvmx-helper-board.c | 1 +
>>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>>
>>>> NAK.
>>>>
>>>> We don't currently support USB, so churning up this file doesn't help
>>>> anything.
>>>
>>> Well, agreed, but why not removing that code entirely then?
>>>
>>
>> That is the eventual plan.
>
> Why not do that now?
>

If others want do submit patches that do that, I would not object. It
is not currently my highest priority, so it may be a little while before
I would get to it.

> Or add USB support to the driver, but don't leave it in the in-kernel
> driver and expect users to know that this is something they shouldn't be
> doing.
>
> Also, why aren't you going to support the USB devices?

I'm not sure where you got that idea. What I said was "We don't
currently support USB...", this doesn't mean that we wouldn't like to
eventually have support for it merged.

> What's wrong with that?

Nothing. You may recall that people are working on getting the driver
merged:

http://marc.info/?l=linux-usb&m=128648942928513

The path of least resistance is to let that patch get merged first, and
then submit the necessary glue to hook it up to OCTEON parts that
support it.

David Daney