Re: [PATCH] staging: octeon: Add Lanai board USB clock type

David Daney
2010-10-11T16:53:08Z

On 10/11/2010 03:09 AM, Bernhard Walle wrote:
> Add the LANAI2 board to __cvmx_helper_board_usb_get_clock_type(). It
> also uses the USB_CLOCK_TYPE_CRYSTAL_12 clock.
>
> Signed-off-by: Bernhard Walle<walle@corscience.de>
> ---
> drivers/staging/octeon/cvmx-helper-board.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

NAK.

We don't currently support USB, so churning up this file doesn't help
anything.

If you are using an out-of-tree driver, you can keep this kind of tweak
out-of-tree as well.

David Daney

>
> diff --git a/drivers/staging/octeon/cvmx-helper-board.c b/drivers/staging/octeon/cvmx-helper-board.c
> index 5793318..f8ae6b4 100644
> --- a/drivers/staging/octeon/cvmx-helper-board.c
> +++ b/drivers/staging/octeon/cvmx-helper-board.c
> @@ -752,6 +752,7 @@ cvmx_helper_board_usb_clock_types_t __cvmx_helper_board_usb_get_clock_type(void)
> {
> switch (cvmx_sysinfo_get()->board_type) {
> case CVMX_BOARD_TYPE_BBGW_REF:
> + case CVMX_BOARD_TYPE_LANAI2_G:
> return USB_CLOCK_TYPE_CRYSTAL_12;
> }
> return USB_CLOCK_TYPE_REF_48;