Re: [PATCH] staging: octeon: Add Lanai board USB clock type

Greg KH
2010-10-12T15:56:31Z

On Mon, Oct 11, 2010 at 10:13:37AM -0700, David Daney wrote:
> On 10/11/2010 10:05 AM, Bernhard Walle wrote:
>> Am 11.10.2010 18:53, schrieb David Daney:
>>> On 10/11/2010 03:09 AM, Bernhard Walle wrote:
>>>> Add the LANAI2 board to __cvmx_helper_board_usb_get_clock_type(). It
>>>> also uses the USB_CLOCK_TYPE_CRYSTAL_12 clock.
>>>>
>>>> Signed-off-by: Bernhard Walle<walle@corscience.de>
>>>> ---
>>>> drivers/staging/octeon/cvmx-helper-board.c | 1 +
>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> NAK.
>>>
>>> We don't currently support USB, so churning up this file doesn't help
>>> anything.
>>
>> Well, agreed, but why not removing that code entirely then?
>>
>
> That is the eventual plan.

Why not do that now?

Or add USB support to the driver, but don't leave it in the in-kernel
driver and expect users to know that this is something they shouldn't be
doing.

Also, why aren't you going to support the USB devices? What's wrong
with that?

thanks,

greg k-h