From: Borislav Petkov <bp@amd64.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Doug Thompson <dougthompson@xmission.com>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] edac/mce_amd: fix shift warning
Date: Thu, 14 Oct 2010 06:24:09 +0200 [thread overview]
Message-ID: <20101014042409.GB29342@aftab> (raw)
In-Reply-To: <20101013131057.88238be6.randy.dunlap@oracle.com>
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Wed, Oct 13, 2010 at 04:10:57PM -0400
> The BIT() macro works on unsigned longs, but this warning happens
> on i386 (X86_32), where UL is 32 bits and this value needs to be
> 64 bits, so use open-coded ULL.
>
> drivers/edac/mce_amd.c:262: warning: left shift count >= width of type
Ok, so BIT() should be fixed to work with the largest type available,
IMHO. Let me cook up something.
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Doug Thompson <dougthompson@xmission.com>
> Cc: Borislav Petkov <borislav.petkov@amd.com>
In the meantime, I'll push your fix to Linus, thanks for testing this on
32-bit :).
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2010-10-14 4:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 20:10 [PATCH -next] edac/mce_amd: fix shift warning Randy Dunlap
2010-10-13 22:39 ` Doug Thompson
2010-10-14 4:24 ` Borislav Petkov [this message]
2010-10-14 10:58 ` [PATCH] bitops.h: Widen BIT macro to support 64-bit types Borislav Petkov
2010-10-14 11:12 ` Matthew Wilcox
2010-10-14 12:12 ` Borislav Petkov
2010-10-14 14:27 ` Matthew Wilcox
2010-10-14 15:03 ` Linus Torvalds
2010-10-14 15:36 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101014042409.GB29342@aftab \
--to=bp@amd64.org \
--cc=akpm@linux-foundation.org \
--cc=dougthompson@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox