From: Andrew Morton <akpm@linux-foundation.org>
To: <michael.hennerich@analog.com>
Cc: linux-kernel@vger.kernel.org, ddbua@analog.com,
drivers@analog.com, mike.frysinger@analog.com,
chrisv@cyberswitching.com
Subject: Re: [PATCH 1/3] drivers: misc: ad525x_dpot: Fix typo in spi write16 and write24 transfer counts
Date: Thu, 14 Oct 2010 15:20:49 -0700 [thread overview]
Message-ID: <20101014152049.9471e1e6.akpm@linux-foundation.org> (raw)
In-Reply-To: <1287046788-25122-1-git-send-email-michael.hennerich@analog.com>
On Thu, 14 Oct 2010 10:59:46 +0200
<michael.hennerich@analog.com> wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> drivers/misc/ad525x_dpot-spi.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/ad525x_dpot-spi.c b/drivers/misc/ad525x_dpot-spi.c
> index b8c6df9..6cfcb63 100644
> --- a/drivers/misc/ad525x_dpot-spi.c
> +++ b/drivers/misc/ad525x_dpot-spi.c
> @@ -53,13 +53,13 @@ static int write8(void *client, u8 val)
> static int write16(void *client, u8 reg, u8 val)
> {
> u8 data[2] = {reg, val};
> - return spi_write(client, data, 1);
> + return spi_write(client, data, 2);
> }
>
> static int write24(void *client, u8 reg, u16 val)
> {
> u8 data[3] = {reg, val >> 8, val};
> - return spi_write(client, data, 1);
> + return spi_write(client, data, 3);
> }
>
> static int read8(void *client)
What are the runtime effects of this change?
next prev parent reply other threads:[~2010-10-14 22:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 8:59 [PATCH 1/3] drivers: misc: ad525x_dpot: Fix typo in spi write16 and write24 transfer counts michael.hennerich
2010-10-14 8:59 ` [PATCH 2/3] drivers: misc: ad525x_dpot: Fix part name typos in defines michael.hennerich
2010-10-14 22:21 ` Andrew Morton
2010-10-15 7:53 ` Hennerich, Michael
2010-10-14 8:59 ` [PATCH 3/3] drivers: misc: ad525x_dpot: new features michael.hennerich
2010-10-14 22:20 ` Andrew Morton [this message]
2010-10-15 7:31 ` [PATCH 1/3] drivers: misc: ad525x_dpot: Fix typo in spi write16 and write24 transfer counts Hennerich, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101014152049.9471e1e6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chrisv@cyberswitching.com \
--cc=ddbua@analog.com \
--cc=drivers@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=mike.frysinger@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox