public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
Cc: linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH resend] Add sc16is7x2 driver
Date: Thu, 14 Oct 2010 12:01:33 -0700	[thread overview]
Message-ID: <20101014190133.GB1009@kroah.com> (raw)
In-Reply-To: <4CAD818B.2070603@iis.fraunhofer.de>

On Thu, Oct 07, 2010 at 10:15:07AM +0200, Manuel Stahl wrote:
> --- /dev/null
> +++ b/include/linux/spi/sc16is7x2.h
> @@ -0,0 +1,17 @@
> +#ifndef LINUX_SPI_SC16IS752_H
> +#define LINUX_SPI_SC16IS752_H
> +
> +#define SC16IS7X2_NR_GPIOS 8
> +
> +struct sc16is7x2_platform_data {
> +	unsigned int	uartclk;
> +	/* uart line number of the first channel */
> +	unsigned	uart_base;
> +	/* number assigned to the first GPIO */
> +	unsigned	gpio_base;
> +	char		*label;
> +	/* list of GPIO names (array length = SC16IS7X2_NR_GPIOS) */
> +	const char	*const *names;
> +};
> +
> +#endif

Why is this needed in a .h file?  What other .c file uses this define
and structure?

thanks,

greg k-h

  reply	other threads:[~2010-10-14 19:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-07  8:15 [PATCH resend] Add sc16is7x2 driver Manuel Stahl
2010-10-14 19:01 ` Greg KH [this message]
2010-10-15  7:24   ` Manuel Stahl
     [not found]     ` <20101015142709.GA18905@kroah.com>
2010-10-15 15:09       ` Manuel Stahl
2010-10-15 16:49         ` Greg KH
2010-10-18  9:46           ` Manuel Stahl
2010-10-19 15:37             ` Greg KH
2010-10-26  8:55               ` Manuel Stahl
2010-10-26 14:51                 ` Greg KH
2010-10-26 14:59                   ` Alan Cox
2010-10-26 19:28                   ` Mark Brown
2010-11-08 14:01 ` Thomas Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101014190133.GB1009@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=manuel.stahl@iis.fraunhofer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox